WARNING: do not add new typedefs #26: FILE: src/include/sof/sof.h:54: + typedef char assertion_failed_##MESSAGE[(COND) ? 1 : -1] CHECK: Please don't use multiple blank lines #28: FILE: src/include/sof/sof.h:56: + + CHECK: Macro argument reuse 'entry' - possible side-effects? #59: FILE: src/include/sof/trace.h:230: +#define BASE_LOG(function_name, entry, ...) \ +{ \ + log_func log_function = NULL; \ + if (PP_NARG(__VA_ARGS__) == 0) { \ + log_function = (log_func)&function_name##0; \ + log_function(entry, ##__VA_ARGS__); \ + } else if (PP_NARG(__VA_ARGS__) == 1) { \ + log_function = (log_func)&function_name##1; \ + log_function(entry, ##__VA_ARGS__); \ + } else if (PP_NARG(__VA_ARGS__) == 2) { \ + log_function = (log_func)&function_name##2; \ + log_function(entry, ##__VA_ARGS__); \ + } else if (PP_NARG(__VA_ARGS__) == 3) { \ + log_function = (log_func)&function_name##3; \ + log_function(entry, ##__VA_ARGS__); \ + } else if (PP_NARG(__VA_ARGS__) == 4) { \ + log_function = (log_func)&function_name##4; \ + log_function(entry, ##__VA_ARGS__); \ + } else { \ + STATIC_ASSERT(PP_NARG(__VA_ARGS__) <= 4, \ + unsupported_amount_of_params_in_trace_event); \ + } \ } total: 0 errors, 1 warnings, 2 checks, 59 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0001-debugability-Protect-against-invalid-param-num-in-tr.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.