CHECK: Prefer using the BIT macro #631: FILE: src/drivers/baytrail/dw-dma.c:127: +#define DW_CTLL_INT_EN (1 << 0) CHECK: Prefer using the BIT macro #635: FILE: src/drivers/baytrail/dw-dma.c:131: +#define DW_CTLL_DST_DEC (1 << 7) CHECK: Prefer using the BIT macro #638: FILE: src/drivers/baytrail/dw-dma.c:134: +#define DW_CTLL_SRC_DEC (1 << 9) CHECK: Prefer using the BIT macro #644: FILE: src/drivers/baytrail/dw-dma.c:140: +#define DW_CTLL_FC_M2P (1 << 20) CHECK: Prefer using the BIT macro #649: FILE: src/drivers/baytrail/dw-dma.c:145: +#define DW_CTLL_LLP_D_EN (1 << 27) CHECK: Prefer using the BIT macro #650: FILE: src/drivers/baytrail/dw-dma.c:146: +#define DW_CTLL_LLP_S_EN (1 << 28) CHECK: Prefer using the BIT macro #651: FILE: src/drivers/baytrail/dw-dma.c:147: +#define DW_CTLL_RELOAD_SRC (1 << 30) CHECK: Prefer using the BIT macro #652: FILE: src/drivers/baytrail/dw-dma.c:148: +#define DW_CTLL_RELOAD_DST (1 << 31) CHECK: Prefer using the BIT macro #657: FILE: src/drivers/baytrail/dw-dma.c:153: +#define DW_CTLL_S_GATH_EN (1 << 17) CHECK: Prefer using the BIT macro #658: FILE: src/drivers/baytrail/dw-dma.c:154: +#define DW_CTLL_D_SCAT_EN (1 << 18) WARNING: line over 80 characters #710: FILE: src/drivers/baytrail/dw-dma.c:206: + void (*cb)(void *data, uint32_t type, struct dma_sg_elem *next); /* client callback function */ CHECK: Alignment should match open parenthesis #723: FILE: src/drivers/baytrail/dw-dma.c:219: +static inline void dw_dma_chan_reload_next(struct dma *dma, int channel, + struct dma_sg_elem *next); CHECK: Alignment should match open parenthesis #736: FILE: src/drivers/baytrail/dw-dma.c:232: +static inline void dw_update_bits(struct dma *dma, uint32_t reg, uint32_t mask, + uint32_t value) CHECK: Blank lines aren't necessary after an open brace '{' #754: FILE: src/drivers/baytrail/dw-dma.c:250: + for (i = 0; i < DW_MAX_CHAN; i++) { + CHECK: Alignment should match open parenthesis #827: FILE: src/drivers/baytrail/dw-dma.c:323: + if (p->chan[channel].status != COMP_STATE_PREPARE || + (dw_read(dma, DW_DMA_CHAN_EN) & (0x1 << channel))) { CHECK: Comparison to NULL could be written "!p->chan[channel].lli" #837: FILE: src/drivers/baytrail/dw-dma.c:333: + if (p->chan[channel].lli == NULL) { WARNING: Block comments use * on subsequent lines #844: FILE: src/drivers/baytrail/dw-dma.c:340: + /* write interrupt clear registers for the channel: + ClearTfr, ClearBlock, ClearSrcTran, ClearDstTran, ClearErr*/ WARNING: Block comments use a trailing */ on a separate line #844: FILE: src/drivers/baytrail/dw-dma.c:340: + ClearTfr, ClearBlock, ClearSrcTran, ClearDstTran, ClearErr*/ CHECK: Alignment should match open parenthesis #951: FILE: src/drivers/baytrail/dw-dma.c:447: +static int dw_dma_status(struct dma *dma, int channel, + struct dma_chan_status *status, uint8_t direction) CHECK: Alignment should match open parenthesis #972: FILE: src/drivers/baytrail/dw-dma.c:468: +static int dw_dma_set_config(struct dma *dma, int channel, + struct dma_sg_config *config) CHECK: Blank lines aren't necessary after an open brace '{' #1006: FILE: src/drivers/baytrail/dw-dma.c:502: + if (desc_count != p->chan[channel].desc_count) { + CHECK: Alignment should match open parenthesis #1013: FILE: src/drivers/baytrail/dw-dma.c:509: + p->chan[channel].lli = rzalloc(RZONE_RUNTIME, + SOF_MEM_CAPS_RAM | SOF_MEM_CAPS_DMA, CHECK: Comparison to NULL could be written "!p->chan[channel].lli" #1015: FILE: src/drivers/baytrail/dw-dma.c:511: + if (p->chan[channel].lli == NULL) { CHECK: multiple assignments should be avoided #1025: FILE: src/drivers/baytrail/dw-dma.c:521: + lli_desc = lli_desc_head = p->chan[channel].lli; CHECK: Blank lines aren't necessary after an open brace '{' #1041: FILE: src/drivers/baytrail/dw-dma.c:537: + list_for_item(plist, &config->elem_list) { + WARNING: line over 80 characters #1101: FILE: src/drivers/baytrail/dw-dma.c:597: + /* config the SINC and DINC field of CTL_LOn, SRC/DST_PER filed of CFGn */ WARNING: line over 80 characters #1114: FILE: src/drivers/baytrail/dw-dma.c:610: + (uint32_t)sg_elem->dest | PLATFORM_HOST_DMA_MASK; WARNING: line over 80 characters #1120: FILE: src/drivers/baytrail/dw-dma.c:616: + lli_desc->sar = (uint32_t)sg_elem->src | PLATFORM_HOST_DMA_MASK; WARNING: line over 80 characters #1121: FILE: src/drivers/baytrail/dw-dma.c:617: + lli_desc->dar = (uint32_t)sg_elem->dest | PLATFORM_HOST_DMA_MASK; WARNING: line over 80 characters #1128: FILE: src/drivers/baytrail/dw-dma.c:624: + lli_desc->sar = (uint32_t)sg_elem->src | PLATFORM_HOST_DMA_MASK; WARNING: line over 80 characters #1137: FILE: src/drivers/baytrail/dw-dma.c:633: + lli_desc->dar = (uint32_t)sg_elem->dest | PLATFORM_HOST_DMA_MASK; CHECK: Alignment should match open parenthesis #1185: FILE: src/drivers/baytrail/dw-dma.c:681: + dcache_writeback_region(p->chan[channel].lli, + sizeof(struct dw_lli2) * p->chan[channel].desc_count); CHECK: Alignment should match open parenthesis #1209: FILE: src/drivers/baytrail/dw-dma.c:705: +static int dw_dma_set_cb(struct dma *dma, int channel, int type, + void (*cb)(void *data, uint32_t type, struct dma_sg_elem *next), CHECK: Alignment should match open parenthesis #1258: FILE: src/drivers/baytrail/dw-dma.c:754: +static inline void dw_dma_chan_reload_next(struct dma *dma, int channel, + struct dma_sg_elem *next) CHECK: Alignment should match open parenthesis #1332: FILE: src/drivers/baytrail/dw-dma.c:828: + dw_write(dma, DW_CTRL_HIGH(i), + DW_CTLH_CLASS(dp->chan[i].class)); WARNING: braces {} are not necessary for single statement blocks #1352: FILE: src/drivers/baytrail/dw-dma.c:848: + if (!status_intr) { + return; + } WARNING: braces {} are not necessary for single statement blocks #1369: FILE: src/drivers/baytrail/dw-dma.c:865: + if (status_err) { + trace_dma_error("eI1"); + } CHECK: Blank lines aren't necessary after an open brace '{' #1385: FILE: src/drivers/baytrail/dw-dma.c:881: + for (i = 0; i < DW_MAX_CHAN; i++) { + CHECK: Alignment should match open parenthesis #1411: FILE: src/drivers/baytrail/dw-dma.c:907: + if ((status_tfr & mask) && + (p->chan[i].cb_type & DMA_IRQ_TYPE_LLIST)) { CHECK: Blank lines aren't necessary after an open brace '{' #1412: FILE: src/drivers/baytrail/dw-dma.c:908: + (p->chan[i].cb_type & DMA_IRQ_TYPE_LLIST)) { + CHECK: Alignment should match open parenthesis #1450: FILE: src/drivers/baytrail/dw-dma.c:946: + dw_pdata = rzalloc(RZONE_SYS, SOF_MEM_CAPS_RAM, + sizeof(*dw_pdata)); CHECK: Prefer using the BIT macro #1951: FILE: src/drivers/haswell/dw-dma.c:127: +#define DW_CTLL_INT_EN (1 << 0) CHECK: Prefer using the BIT macro #1955: FILE: src/drivers/haswell/dw-dma.c:131: +#define DW_CTLL_DST_DEC (1 << 7) CHECK: Prefer using the BIT macro #1958: FILE: src/drivers/haswell/dw-dma.c:134: +#define DW_CTLL_SRC_DEC (1 << 9) CHECK: Prefer using the BIT macro #1964: FILE: src/drivers/haswell/dw-dma.c:140: +#define DW_CTLL_FC_M2P (1 << 20) CHECK: Prefer using the BIT macro #1969: FILE: src/drivers/haswell/dw-dma.c:145: +#define DW_CTLL_LLP_D_EN (1 << 27) CHECK: Prefer using the BIT macro #1970: FILE: src/drivers/haswell/dw-dma.c:146: +#define DW_CTLL_LLP_S_EN (1 << 28) CHECK: Prefer using the BIT macro #1971: FILE: src/drivers/haswell/dw-dma.c:147: +#define DW_CTLL_RELOAD_SRC (1 << 30) CHECK: Prefer using the BIT macro #1972: FILE: src/drivers/haswell/dw-dma.c:148: +#define DW_CTLL_RELOAD_DST (1 << 31) WARNING: line over 80 characters #2016: FILE: src/drivers/haswell/dw-dma.c:192: + void (*cb)(void *data, uint32_t type, struct dma_sg_elem *next); /* client callback function */ CHECK: Alignment should match open parenthesis #2029: FILE: src/drivers/haswell/dw-dma.c:205: +static inline void dw_dma_chan_reload_next(struct dma *dma, int channel, + struct dma_sg_elem *next); CHECK: Alignment should match open parenthesis #2042: FILE: src/drivers/haswell/dw-dma.c:218: +static inline void dw_update_bits(struct dma *dma, uint32_t reg, uint32_t mask, + uint32_t value) CHECK: Blank lines aren't necessary after an open brace '{' #2060: FILE: src/drivers/haswell/dw-dma.c:236: + for (i = 0; i < DW_MAX_CHAN; i++) { + CHECK: Alignment should match open parenthesis #2133: FILE: src/drivers/haswell/dw-dma.c:309: + if (p->chan[channel].status != COMP_STATE_PREPARE || + (dw_read(dma, DW_DMA_CHAN_EN) & (0x1 << channel))) { CHECK: Comparison to NULL could be written "!p->chan[channel].lli" #2143: FILE: src/drivers/haswell/dw-dma.c:319: + if (p->chan[channel].lli == NULL) { WARNING: Block comments use * on subsequent lines #2150: FILE: src/drivers/haswell/dw-dma.c:326: + /* write interrupt clear registers for the channel: + ClearTfr, ClearBlock, ClearSrcTran, ClearDstTran, ClearErr*/ WARNING: Block comments use a trailing */ on a separate line #2150: FILE: src/drivers/haswell/dw-dma.c:326: + ClearTfr, ClearBlock, ClearSrcTran, ClearDstTran, ClearErr*/ CHECK: Alignment should match open parenthesis #2257: FILE: src/drivers/haswell/dw-dma.c:433: +static int dw_dma_status(struct dma *dma, int channel, + struct dma_chan_status *status, uint8_t direction) CHECK: Alignment should match open parenthesis #2278: FILE: src/drivers/haswell/dw-dma.c:454: +static int dw_dma_set_config(struct dma *dma, int channel, + struct dma_sg_config *config) CHECK: Blank lines aren't necessary after an open brace '{' #2312: FILE: src/drivers/haswell/dw-dma.c:488: + if (desc_count != p->chan[channel].desc_count) { + CHECK: Alignment should match open parenthesis #2319: FILE: src/drivers/haswell/dw-dma.c:495: + p->chan[channel].lli = rzalloc(RZONE_RUNTIME, + SOF_MEM_CAPS_RAM | SOF_MEM_CAPS_DMA, CHECK: Comparison to NULL could be written "!p->chan[channel].lli" #2321: FILE: src/drivers/haswell/dw-dma.c:497: + if (p->chan[channel].lli == NULL) { CHECK: multiple assignments should be avoided #2331: FILE: src/drivers/haswell/dw-dma.c:507: + lli_desc = lli_desc_head = p->chan[channel].lli; CHECK: Blank lines aren't necessary after an open brace '{' #2347: FILE: src/drivers/haswell/dw-dma.c:523: + list_for_item(plist, &config->elem_list) { + WARNING: line over 80 characters #2407: FILE: src/drivers/haswell/dw-dma.c:583: + /* config the SINC and DINC field of CTL_LOn, SRC/DST_PER filed of CFGn */ WARNING: line over 80 characters #2420: FILE: src/drivers/haswell/dw-dma.c:596: + (uint32_t)sg_elem->dest | PLATFORM_HOST_DMA_MASK; WARNING: line over 80 characters #2426: FILE: src/drivers/haswell/dw-dma.c:602: + lli_desc->sar = (uint32_t)sg_elem->src | PLATFORM_HOST_DMA_MASK; WARNING: line over 80 characters #2427: FILE: src/drivers/haswell/dw-dma.c:603: + lli_desc->dar = (uint32_t)sg_elem->dest | PLATFORM_HOST_DMA_MASK; WARNING: line over 80 characters #2434: FILE: src/drivers/haswell/dw-dma.c:610: + lli_desc->sar = (uint32_t)sg_elem->src | PLATFORM_HOST_DMA_MASK; WARNING: line over 80 characters #2443: FILE: src/drivers/haswell/dw-dma.c:619: + lli_desc->dar = (uint32_t)sg_elem->dest | PLATFORM_HOST_DMA_MASK; WARNING: line over 80 characters #2468: FILE: src/drivers/haswell/dw-dma.c:644: + lli_desc->ctrl_hi = (sg_elem->size / (1 << (lli_desc->ctrl_lo >> 4 & 0x7))) CHECK: Alignment should match open parenthesis #2493: FILE: src/drivers/haswell/dw-dma.c:669: + dcache_writeback_region(p->chan[channel].lli, + sizeof(struct dw_lli2) * p->chan[channel].desc_count); CHECK: Alignment should match open parenthesis #2517: FILE: src/drivers/haswell/dw-dma.c:693: +static int dw_dma_set_cb(struct dma *dma, int channel, int type, + void (*cb)(void *data, uint32_t type, struct dma_sg_elem *next), CHECK: Alignment should match open parenthesis #2566: FILE: src/drivers/haswell/dw-dma.c:742: +static inline void dw_dma_chan_reload_next(struct dma *dma, int channel, + struct dma_sg_elem *next) CHECK: Alignment should match open parenthesis #2641: FILE: src/drivers/haswell/dw-dma.c:817: + dw_write(dma, DW_CFG_LOW(i), + DW_CFG_CLASS(dp->chan[i].class)); WARNING: braces {} are not necessary for single statement blocks #2661: FILE: src/drivers/haswell/dw-dma.c:837: + if (!status_intr) { + return; + } WARNING: braces {} are not necessary for single statement blocks #2678: FILE: src/drivers/haswell/dw-dma.c:854: + if (status_err) { + trace_dma_error("eI1"); + } CHECK: Blank lines aren't necessary after an open brace '{' #2694: FILE: src/drivers/haswell/dw-dma.c:870: + for (i = 0; i < DW_MAX_CHAN; i++) { + CHECK: Alignment should match open parenthesis #2720: FILE: src/drivers/haswell/dw-dma.c:896: + if ((status_tfr & mask) && + (p->chan[i].cb_type & DMA_IRQ_TYPE_LLIST)) { CHECK: Blank lines aren't necessary after an open brace '{' #2721: FILE: src/drivers/haswell/dw-dma.c:897: + (p->chan[i].cb_type & DMA_IRQ_TYPE_LLIST)) { + CHECK: Alignment should match open parenthesis #2759: FILE: src/drivers/haswell/dw-dma.c:935: + dw_pdata = rzalloc(RZONE_SYS, SOF_MEM_CAPS_RAM, + sizeof(*dw_pdata)); total: 0 errors, 23 warnings, 58 checks, 3167 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0001-platform-refactor-move-clk-irq-timer-to-drivers.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.