CHECK: Alignment should match open parenthesis
#94: FILE: src/include/sof/trace.h:130:
+void _trace_event_mbox_atomic2(uint32_t log_entry, uint32_t param1,
+	uint32_t param2);

CHECK: Alignment should match open parenthesis
#97: FILE: src/include/sof/trace.h:133:
+void _trace_event3(uint32_t log_entry, uint32_t param1, uint32_t param2,
+	uint32_t param3);

CHECK: Alignment should match open parenthesis
#99: FILE: src/include/sof/trace.h:135:
+void _trace_event_mbox3(uint32_t log_entry, uint32_t param1, uint32_t param2,
+	uint32_t param3);

CHECK: Alignment should match open parenthesis
#101: FILE: src/include/sof/trace.h:137:
+void _trace_event_atomic3(uint32_t log_entry, uint32_t param1, uint32_t param2,
+	uint32_t param3);

CHECK: Alignment should match open parenthesis
#103: FILE: src/include/sof/trace.h:139:
+void _trace_event_mbox_atomic3(uint32_t log_entry, uint32_t param1,
+	uint32_t param2, uint32_t param3);

CHECK: Macro argument reuse 'format' - possible side-effects?
#113: FILE: src/include/sof/trace.h:149:
+#define _DECLARE_LOG_ENTRY(lvl, format, comp_id, params)\
+	__attribute__((section(".static_log." #lvl)))	\
+	__attribute__((aligned(128)))			\
+	static const struct {				\
+		uint32_t level;				\
+		uint32_t component_id;			\
+		uint32_t params_num;			\
+		uint32_t line_idx;			\
+		uint32_t file_name_len;			\
+		const char file_name[sizeof(__FILE__)];	\
+		uint32_t text_len;			\
+		const char text[sizeof(format)];	\
+	} log_entry = {					\
+		lvl,					\
+		comp_id,				\
+		params,					\
+		__LINE__,				\
+		sizeof(__FILE__),			\
+		__FILE__,				\
+		sizeof(format),				\
+		format					\
+	}

WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
#115: FILE: src/include/sof/trace.h:151:
+	__attribute__((aligned(128)))			\

ERROR: space required after that ',' (ctx:VxO)
#167: FILE: src/include/sof/trace.h:199:
+	_log_message(_mbox,, LOG_LEVEL_VERBOSE, __c, __e, ##__VA_ARGS__)
 	                  ^

ERROR: space required after that ',' (ctx:BxO)
#177: FILE: src/include/sof/trace.h:205:
+	_log_message(,, LOG_LEVEL_VERBOSE, __c, __e, ##__VA_ARGS__)
 	             ^

ERROR: space required after that ',' (ctx:BxO)
#215: FILE: src/include/sof/trace.h:231:
+	_log_message(,, LOG_LEVEL_CRITICAL, __c, __e, ##__VA_ARGS__)
 	             ^

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#409: FILE: src/lib/trace.c:50:
+static void put_header(volatile uint32_t *dst, uint64_t timestamp)

CHECK: Alignment should match open parenthesis
#469: FILE: src/lib/trace.c:100:
+	dtrace_event_atomic((const char *)dt,
+		sizeof(uint32_t) * message_size_dwords);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#486: FILE: src/lib/trace.c:114:
+	volatile uint32_t *t;

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#507: FILE: src/lib/trace.c:130:
+	t = (volatile uint32_t *)(MAILBOX_TRACE_BASE + trace->pos);

CHECK: Alignment should match open parenthesis
#525: FILE: src/lib/trace.c:144:
+	dcache_writeback_region((void *)t,
+		sizeof(uint32_t) * message_size_dwords);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#533: FILE: src/lib/trace.c:149:
+	volatile uint32_t *t;

CHECK: Alignment should match open parenthesis
#552: FILE: src/lib/trace.c:165:
+	dtrace_event_atomic((const char *)dt,
+		sizeof(uint32_t) * message_size_dwords);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#557: FILE: src/lib/trace.c:168:
+	t = (volatile uint32_t *)(MAILBOX_TRACE_BASE + trace->pos);

CHECK: Alignment should match open parenthesis
#569: FILE: src/lib/trace.c:180:
+	dcache_writeback_region((void *)t,
+		sizeof(uint32_t) * message_size_dwords);

CHECK: Alignment should match open parenthesis
#607: FILE: src/lib/trace.c:218:
+	dtrace_event_atomic((const char *)dt,
+		sizeof(uint32_t) * message_size_dwords);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#621: FILE: src/lib/trace.c:232:
+	volatile uint32_t *t;

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#638: FILE: src/lib/trace.c:249:
+	t = (volatile uint32_t *)(MAILBOX_TRACE_BASE + trace->pos);

CHECK: Alignment should match open parenthesis
#653: FILE: src/lib/trace.c:264:
+	dcache_writeback_region((void *)t,
+		sizeof(uint32_t) * message_size_dwords);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#658: FILE: src/lib/trace.c:269:
+	volatile uint32_t *t;

CHECK: Alignment should match open parenthesis
#675: FILE: src/lib/trace.c:286:
+	dtrace_event_atomic((const char *)dt,
+		sizeof(uint32_t) * message_size_dwords);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#678: FILE: src/lib/trace.c:289:
+	t = (volatile uint32_t *)(MAILBOX_TRACE_BASE + trace->pos);

CHECK: Alignment should match open parenthesis
#691: FILE: src/lib/trace.c:302:
+	dcache_writeback_region((void *)t,
+		sizeof(uint32_t) * message_size_dwords);

CHECK: Alignment should match open parenthesis
#731: FILE: src/lib/trace.c:342:
+	dtrace_event_atomic((const char *)dt,
+		sizeof(uint32_t) * message_size_dwords);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#745: FILE: src/lib/trace.c:356:
+	volatile uint32_t *t;

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#763: FILE: src/lib/trace.c:374:
+	t = (volatile uint32_t *)(MAILBOX_TRACE_BASE + trace->pos);

CHECK: Alignment should match open parenthesis
#779: FILE: src/lib/trace.c:390:
+	dcache_writeback_region((void *)t,
+		sizeof(uint32_t) * message_size_dwords);

CHECK: Alignment should match open parenthesis
#783: FILE: src/lib/trace.c:394:
+void _trace_event_mbox_atomic2(uint32_t log_entry, uint32_t param1,
+	uint32_t param2)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#785: FILE: src/lib/trace.c:396:
+	volatile uint32_t *t;

CHECK: Alignment should match open parenthesis
#803: FILE: src/lib/trace.c:414:
+	dtrace_event_atomic((const char *)dt,
+		sizeof(uint32_t) * message_size_dwords);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#806: FILE: src/lib/trace.c:417:
+	t = (volatile uint32_t *)(MAILBOX_TRACE_BASE + trace->pos);

CHECK: Alignment should match open parenthesis
#820: FILE: src/lib/trace.c:431:
+	dcache_writeback_region((void *)t,
+		sizeof(uint32_t) * message_size_dwords);

CHECK: Alignment should match open parenthesis
#825: FILE: src/lib/trace.c:436:
+void _trace_event3(uint32_t log_entry, uint32_t param1, uint32_t param2,
+	uint32_t param3)

CHECK: Alignment should match open parenthesis
#846: FILE: src/lib/trace.c:457:
+void _trace_event_atomic3(uint32_t log_entry, uint32_t param1, uint32_t param2,
+	uint32_t param3)

CHECK: Alignment should match open parenthesis
#864: FILE: src/lib/trace.c:475:
+	dtrace_event_atomic((const char *)dt,
+		sizeof(uint32_t) * message_size_dwords);

CHECK: Alignment should match open parenthesis
#869: FILE: src/lib/trace.c:480:
+void _trace_event_mbox3(uint32_t log_entry, uint32_t param1, uint32_t param2,
+	uint32_t param3)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#879: FILE: src/lib/trace.c:490:
+	volatile uint32_t *t;

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#898: FILE: src/lib/trace.c:509:
+	t = (volatile uint32_t *)(MAILBOX_TRACE_BASE + trace->pos);

CHECK: Alignment should match open parenthesis
#915: FILE: src/lib/trace.c:526:
+	dcache_writeback_region((void *)t,
+		sizeof(uint32_t) * message_size_dwords);

CHECK: Alignment should match open parenthesis
#919: FILE: src/lib/trace.c:530:
+void _trace_event_mbox_atomic3(uint32_t log_entry, uint32_t param1,
+	uint32_t param2, uint32_t param3)

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#921: FILE: src/lib/trace.c:532:
+	volatile uint32_t *t;

CHECK: Alignment should match open parenthesis
#940: FILE: src/lib/trace.c:551:
+	dtrace_event_atomic((const char *)dt,
+		sizeof(uint32_t) * message_size_dwords);

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#943: FILE: src/lib/trace.c:554:
+	t = (volatile uint32_t *)(MAILBOX_TRACE_BASE + trace->pos);

CHECK: Alignment should match open parenthesis
#962: FILE: src/lib/trace.c:569:
+	dcache_writeback_region((void *)t,
+		sizeof(uint32_t) * message_size_dwords);

total: 3 errors, 18 warnings, 27 checks, 1063 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

0001-debugability-logging-Redesign-tracing-mechanism-to-e.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.