CHECK: Alignment should match open parenthesis #29: FILE: rimage/elf.c:92: + module->logs_index = elf_find_section(image, module, + ".static_log_entries"); WARNING: line over 80 characters #104: FILE: rimage/file_simple.c:361: + Elf32_Shdr *section = &module->section[module->logs_index]; CHECK: Avoid CamelCase: #104: FILE: rimage/file_simple.c:361: + Elf32_Shdr *section = &module->section[module->logs_index]; CHECK: Alignment should match open parenthesis #110: FILE: rimage/file_simple.c:367: + fwrite(&header, sizeof(struct snd_sof_logs_header), 1, + image->ldc_out_fd); WARNING: line over 80 characters #120: FILE: rimage/file_simple.c:377: + fprintf(stderr, "error: can't read section %d\n", CHECK: Alignment should match open parenthesis #126: FILE: rimage/file_simple.c:383: + count = fwrite(buffer, 1, section->sh_size, + image->ldc_out_fd); WARNING: line over 80 characters #128: FILE: rimage/file_simple.c:385: + fprintf(stderr, "error: can't write section %d\n", CHECK: Comparison to NULL could be written "!image.ldc_out_file" #180: FILE: rimage/rimage.c:96: + if (image.ldc_out_file == NULL) CHECK: Comparison to NULL could be written "!image.ldc_out_fd" #192: FILE: rimage/rimage.c:148: + if (image.ldc_out_fd == NULL) { total: 0 errors, 3 warnings, 6 checks, 201 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0001-debugability-rimage-extract-.static_log_entries-from.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.