WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: Also added SOF_ABI_VERSION_INCOMPATIBLE macro to allow for easier comparison CHECK: spaces preferred around that '<<' (ctx:VxV) #28: FILE: src/include/uapi/abi.h:42: + (((major)<<8)|((minor)<<4)|(micro)) ^ CHECK: spaces preferred around that '|' (ctx:VxV) #28: FILE: src/include/uapi/abi.h:42: + (((major)<<8)|((minor)<<4)|(micro)) ^ CHECK: spaces preferred around that '<<' (ctx:VxV) #28: FILE: src/include/uapi/abi.h:42: + (((major)<<8)|((minor)<<4)|(micro)) ^ CHECK: spaces preferred around that '|' (ctx:VxV) #28: FILE: src/include/uapi/abi.h:42: + (((major)<<8)|((minor)<<4)|(micro)) ^ CHECK: spaces preferred around that '>>' (ctx:VxV) #29: FILE: src/include/uapi/abi.h:43: +#define SOF_ABI_VERSION_MAJOR(version) (((version)>>8) & 0xff) ^ CHECK: spaces preferred around that '>>' (ctx:VxV) #30: FILE: src/include/uapi/abi.h:44: +#define SOF_ABI_VERSION_MINOR(version) (((version)>>4) & 0xf) ^ CHECK: Macro argument reuse 'sof_ver' - possible side-effects? #32: FILE: src/include/uapi/abi.h:46: +#define SOF_ABI_VERSION_INCOMPATIBLE(sof_ver, client_ver) \ + (SOF_ABI_VERSION_MAJOR(sof_ver) != SOF_ABI_VERSION_MAJOR(client_ver) ||\ + (SOF_ABI_VERSION_MAJOR(sof_ver) == SOF_ABI_VERSION_MAJOR(client_ver) &&\ + SOF_ABI_VERSION_MINOR(sof_ver) != SOF_ABI_VERSION_MINOR(client_ver))) CHECK: Macro argument reuse 'client_ver' - possible side-effects? #32: FILE: src/include/uapi/abi.h:46: +#define SOF_ABI_VERSION_INCOMPATIBLE(sof_ver, client_ver) \ + (SOF_ABI_VERSION_MAJOR(sof_ver) != SOF_ABI_VERSION_MAJOR(client_ver) ||\ + (SOF_ABI_VERSION_MAJOR(sof_ver) == SOF_ABI_VERSION_MAJOR(client_ver) &&\ + SOF_ABI_VERSION_MINOR(sof_ver) != SOF_ABI_VERSION_MINOR(client_ver))) total: 0 errors, 1 warnings, 8 checks, 22 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. 0001-abi-Redefine-SOF_ABI_VERSION-to-allow-for-backward-c.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.