WARNING: please write a paragraph that describes the config symbol fully #22: FILE: drivers/rpmsg/Kconfig:31: +config RPMSG_RTC WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #44: new file mode 100644 WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #49: FILE: drivers/rpmsg/rpmsg_rtc.c:1: +/* SPDX-License-Identifier: GPL-2.0 */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #68: FILE: drivers/rpmsg/rpmsg_rtc.c:20: + uint32_t command; CHECK: Prefer kernel type 's32' over 'int32_t' #69: FILE: drivers/rpmsg/rpmsg_rtc.c:21: + int32_t result; CHECK: Prefer kernel type 'u64' over 'uint64_t' #70: FILE: drivers/rpmsg/rpmsg_rtc.c:22: + uint64_t cookie; CHECK: Prefer kernel type 's64' over 'int64_t' #75: FILE: drivers/rpmsg/rpmsg_rtc.c:27: + int64_t sec; CHECK: Prefer kernel type 's32' over 'int32_t' #76: FILE: drivers/rpmsg/rpmsg_rtc.c:28: + int32_t nsec; CHECK: Prefer kernel type 's64' over 'int64_t' #83: FILE: drivers/rpmsg/rpmsg_rtc.c:35: + int64_t sec; CHECK: Prefer kernel type 's32' over 'int32_t' #84: FILE: drivers/rpmsg/rpmsg_rtc.c:36: + int32_t nsec; CHECK: Prefer kernel type 'u32' over 'uint32_t' #85: FILE: drivers/rpmsg/rpmsg_rtc.c:37: + uint32_t id; CHECK: Prefer kernel type 'u32' over 'uint32_t' #90: FILE: drivers/rpmsg/rpmsg_rtc.c:42: + uint32_t id; CHECK: Alignment should match open parenthesis #106: FILE: drivers/rpmsg/rpmsg_rtc.c:58: +static int rpmsg_rtc_set_handler(struct rpmsg_device *rpdev, + void *data, int len, void *priv, u32 src) CHECK: Alignment should match open parenthesis #119: FILE: drivers/rpmsg/rpmsg_rtc.c:71: +static int rpmsg_rtc_get_handler(struct rpmsg_device *rpdev, + void *data, int len, void *priv, u32 src) CHECK: Alignment should match open parenthesis #157: FILE: drivers/rpmsg/rpmsg_rtc.c:109: +static int rpmsg_rtc_alarm_set_handler(struct rpmsg_device *rpdev, + void *data, int len, void *priv_, u32 src) CHECK: Comparison to NULL could be written "!alarm" #164: FILE: drivers/rpmsg/rpmsg_rtc.c:116: + if (alarm == NULL) { WARNING: line over 80 characters #170: FILE: drivers/rpmsg/rpmsg_rtc.c:122: + alarm_init(&alarm->alarm, ALARM_REALTIME, rpmsg_rtc_alarm_func); WARNING: line over 80 characters #171: FILE: drivers/rpmsg/rpmsg_rtc.c:123: + if (idr_alloc(&priv->alarms, alarm, msg->id, msg->id, GFP_KERNEL) < 0) { CHECK: braces {} should be used on all arms of this statement #178: FILE: drivers/rpmsg/rpmsg_rtc.c:130: + if (alarm) { [...] + } else [...] CHECK: Unbalanced braces around else statement #181: FILE: drivers/rpmsg/rpmsg_rtc.c:133: + } else CHECK: Alignment should match open parenthesis #188: FILE: drivers/rpmsg/rpmsg_rtc.c:140: +static int rpmsg_rtc_alarm_cancel_handler(struct rpmsg_device *rpdev, + void *data, int len, void *priv_, u32 src) CHECK: Alignment should match open parenthesis #214: FILE: drivers/rpmsg/rpmsg_rtc.c:166: +static int rpmsg_rtc_callback(struct rpmsg_device *rpdev, + void *data, int len, void *priv, u32 src) CHECK: Prefer kernel type 'u32' over 'uint32_t' #217: FILE: drivers/rpmsg/rpmsg_rtc.c:169: + uint32_t command = header->command; WARNING: line over 80 characters #223: FILE: drivers/rpmsg/rpmsg_rtc.c:175: + dev_err(&rpdev->dev, "command handle error %d\n", command); CHECK: Alignment should match open parenthesis #277: FILE: drivers/rpmsg/rpmsg_rtc.c:229: +module_driver(rpmsg_rtc_driver, + register_rpmsg_driver, total: 0 errors, 6 warnings, 19 checks, 254 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./linux-sof-driver/0001-rpmsg-Add-rtc-API-redirection-driver.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.