CHECK: Please don't use multiple blank lines #21: FILE: include/uapi/sound/sof-abi.h:12: + CHECK: spaces preferred around that '<<' (ctx:VxV) #23: FILE: include/uapi/sound/sof-abi.h:14: + (((major)<<8)|((minor)<<4)|(micro)) ^ CHECK: spaces preferred around that '|' (ctx:VxV) #23: FILE: include/uapi/sound/sof-abi.h:14: + (((major)<<8)|((minor)<<4)|(micro)) ^ CHECK: spaces preferred around that '<<' (ctx:VxV) #23: FILE: include/uapi/sound/sof-abi.h:14: + (((major)<<8)|((minor)<<4)|(micro)) ^ CHECK: spaces preferred around that '|' (ctx:VxV) #23: FILE: include/uapi/sound/sof-abi.h:14: + (((major)<<8)|((minor)<<4)|(micro)) ^ CHECK: spaces preferred around that '>>' (ctx:VxV) #24: FILE: include/uapi/sound/sof-abi.h:15: +#define SOF_ABI_VERSION_MAJOR(version) (((version)>>8) & 0xff) ^ CHECK: spaces preferred around that '>>' (ctx:VxV) #25: FILE: include/uapi/sound/sof-abi.h:16: +#define SOF_ABI_VERSION_MINOR(version) (((version)>>4) & 0xf) ^ CHECK: Macro argument reuse 'sof_ver' - possible side-effects? #27: FILE: include/uapi/sound/sof-abi.h:18: +#define SOF_ABI_VERSION_INCOMPATIBLE(sof_ver, client_ver) \ + (SOF_ABI_VERSION_MAJOR(sof_ver) != SOF_ABI_VERSION_MAJOR(client_ver) ||\ + (SOF_ABI_VERSION_MAJOR(sof_ver) == SOF_ABI_VERSION_MAJOR(client_ver) &&\ + SOF_ABI_VERSION_MINOR(sof_ver) != SOF_ABI_VERSION_MINOR(client_ver))) CHECK: Macro argument reuse 'client_ver' - possible side-effects? #27: FILE: include/uapi/sound/sof-abi.h:18: +#define SOF_ABI_VERSION_INCOMPATIBLE(sof_ver, client_ver) \ + (SOF_ABI_VERSION_MAJOR(sof_ver) != SOF_ABI_VERSION_MAJOR(client_ver) ||\ + (SOF_ABI_VERSION_MAJOR(sof_ver) == SOF_ABI_VERSION_MAJOR(client_ver) &&\ + SOF_ABI_VERSION_MINOR(sof_ver) != SOF_ABI_VERSION_MINOR(client_ver))) total: 0 errors, 0 warnings, 9 checks, 24 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./linux-sof-driver/0001-SOF-Update-uapi-sof-abi.h-header-to-conform-to-curre.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.