WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: include/uapi/sound/{sof-eq.h => sof/eq.h} | 46 +- WARNING: line over 80 characters #92: FILE: include/sound/sof/control.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #94: FILE: include/sound/sof/control.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or WARNING: please, no space before tabs #168: FILE: include/sound/sof/control.h:77: +^ISOF_CTRL_CMD_ENUM, ^I/**< maps to ALSA enum style controls */$ WARNING: please, no space before tabs #169: FILE: include/sound/sof/control.h:78: +^ISOF_CTRL_CMD_SWITCH, ^I/**< maps to ALSA switch style controls */$ WARNING: please, no space before tabs #170: FILE: include/sound/sof/control.h:79: +^ISOF_CTRL_CMD_BINARY, ^I/**< maps to ALSA binary style controls */$ CHECK: Prefer kernel type 'u32' over 'uint32_t' #175: FILE: include/sound/sof/control.h:84: + uint32_t channel; /**< channel map - enum sof_ipc_chmap */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #176: FILE: include/sound/sof/control.h:85: + uint32_t value; WARNING: __packed is preferred over __attribute__((packed)) #177: FILE: include/sound/sof/control.h:86: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #181: FILE: include/sound/sof/control.h:90: + uint32_t index; /**< component source/sink/control index in control */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #183: FILE: include/sound/sof/control.h:92: + uint32_t uvalue; CHECK: Prefer kernel type 's32' over 'int32_t' #184: FILE: include/sound/sof/control.h:93: + int32_t svalue; WARNING: __packed is preferred over __attribute__((packed)) #186: FILE: include/sound/sof/control.h:95: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #191: FILE: include/sound/sof/control.h:100: + uint32_t comp_id; CHECK: Prefer kernel type 'u32' over 'uint32_t' #194: FILE: include/sound/sof/control.h:103: + uint32_t type; /**< enum sof_ipc_ctrl_type */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #195: FILE: include/sound/sof/control.h:104: + uint32_t cmd; /**< enum sof_ipc_ctrl_cmd */ WARNING: please, no space before tabs #196: FILE: include/sound/sof/control.h:105: +^Iuint32_t index; ^I/**< control index for comps > 1 control */$ CHECK: Prefer kernel type 'u32' over 'uint32_t' #196: FILE: include/sound/sof/control.h:105: + uint32_t index; /**< control index for comps > 1 control */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #200: FILE: include/sound/sof/control.h:109: + uint32_t num_elems; /**< in array elems or bytes */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #203: FILE: include/sound/sof/control.h:112: + uint32_t reserved[8]; WARNING: __packed is preferred over __attribute__((packed)) #214: FILE: include/sound/sof/control.h:123: +} __attribute__((packed)); WARNING: line over 80 characters #223: FILE: include/sound/sof/dai-intel.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #225: FILE: include/sound/sof/dai-intel.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or CHECK: Prefer using the BIT macro #237: FILE: include/sound/sof/dai-intel.h:15: +#define SOF_DAI_INTEL_SSP_QUIRK_TINTE (1 << 0) CHECK: Prefer using the BIT macro #239: FILE: include/sound/sof/dai-intel.h:17: +#define SOF_DAI_INTEL_SSP_QUIRK_PINTE (1 << 1) CHECK: Prefer using the BIT macro #241: FILE: include/sound/sof/dai-intel.h:19: +#define SOF_DAI_INTEL_SSP_QUIRK_SMTATF (1 << 2) CHECK: Prefer using the BIT macro #243: FILE: include/sound/sof/dai-intel.h:21: +#define SOF_DAI_INTEL_SSP_QUIRK_MMRATF (1 << 3) CHECK: Prefer using the BIT macro #245: FILE: include/sound/sof/dai-intel.h:23: +#define SOF_DAI_INTEL_SSP_QUIRK_PSPSTWFDFD (1 << 4) CHECK: Prefer using the BIT macro #247: FILE: include/sound/sof/dai-intel.h:25: +#define SOF_DAI_INTEL_SSP_QUIRK_PSPSRWFDFD (1 << 5) CHECK: Please don't use multiple blank lines #271: FILE: include/sound/sof/dai-intel.h:49: + + CHECK: Prefer kernel type 'u16' over 'uint16_t' #274: FILE: include/sound/sof/dai-intel.h:52: + uint16_t reserved1; CHECK: Prefer kernel type 'u16' over 'uint16_t' #275: FILE: include/sound/sof/dai-intel.h:53: + uint16_t mclk_id; CHECK: Prefer kernel type 'u32' over 'uint32_t' #277: FILE: include/sound/sof/dai-intel.h:55: + uint32_t mclk_rate; /* mclk frequency in Hz */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #278: FILE: include/sound/sof/dai-intel.h:56: + uint32_t fsync_rate; /* fsync frequency in Hz */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #279: FILE: include/sound/sof/dai-intel.h:57: + uint32_t bclk_rate; /* bclk frequency in Hz */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #282: FILE: include/sound/sof/dai-intel.h:60: + uint32_t tdm_slots; CHECK: Prefer kernel type 'u32' over 'uint32_t' #283: FILE: include/sound/sof/dai-intel.h:61: + uint32_t rx_slots; CHECK: Prefer kernel type 'u32' over 'uint32_t' #284: FILE: include/sound/sof/dai-intel.h:62: + uint32_t tx_slots; CHECK: Prefer kernel type 'u32' over 'uint32_t' #287: FILE: include/sound/sof/dai-intel.h:65: + uint32_t sample_valid_bits; CHECK: Prefer kernel type 'u16' over 'uint16_t' #288: FILE: include/sound/sof/dai-intel.h:66: + uint16_t tdm_slot_width; CHECK: Prefer kernel type 'u16' over 'uint16_t' #289: FILE: include/sound/sof/dai-intel.h:67: + uint16_t reserved2; /* alignment */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #292: FILE: include/sound/sof/dai-intel.h:70: + uint32_t mclk_direction; CHECK: Prefer kernel type 'u16' over 'uint16_t' #294: FILE: include/sound/sof/dai-intel.h:72: + uint16_t frame_pulse_width; CHECK: Prefer kernel type 'u16' over 'uint16_t' #295: FILE: include/sound/sof/dai-intel.h:73: + uint16_t tdm_per_slot_padding_flag; CHECK: Prefer kernel type 'u32' over 'uint32_t' #296: FILE: include/sound/sof/dai-intel.h:74: + uint32_t clks_control; CHECK: Prefer kernel type 'u32' over 'uint32_t' #297: FILE: include/sound/sof/dai-intel.h:75: + uint32_t quirks; WARNING: __packed is preferred over __attribute__((packed)) #298: FILE: include/sound/sof/dai-intel.h:76: +} __attribute__((packed)); WARNING: __packed is preferred over __attribute__((packed)) #304: FILE: include/sound/sof/dai-intel.h:82: +} __attribute__((packed)); WARNING: please, no space before tabs #326: FILE: include/sound/sof/dai-intel.h:104: +^Iuint16_t id; ^I^I/**< PDM controller ID */$ CHECK: Prefer kernel type 'u16' over 'uint16_t' #326: FILE: include/sound/sof/dai-intel.h:104: + uint16_t id; /**< PDM controller ID */ WARNING: please, no space before tabs #328: FILE: include/sound/sof/dai-intel.h:106: +^Iuint16_t enable_mic_a; ^I/**< Use A (left) channel mic (0 or 1)*/$ CHECK: Prefer kernel type 'u16' over 'uint16_t' #328: FILE: include/sound/sof/dai-intel.h:106: + uint16_t enable_mic_a; /**< Use A (left) channel mic (0 or 1)*/ WARNING: please, no space before tabs #329: FILE: include/sound/sof/dai-intel.h:107: +^Iuint16_t enable_mic_b; ^I/**< Use B (right) channel mic (0 or 1)*/$ CHECK: Prefer kernel type 'u16' over 'uint16_t' #329: FILE: include/sound/sof/dai-intel.h:107: + uint16_t enable_mic_b; /**< Use B (right) channel mic (0 or 1)*/ CHECK: Prefer kernel type 'u16' over 'uint16_t' #331: FILE: include/sound/sof/dai-intel.h:109: + uint16_t polarity_mic_a; /**< Optionally invert mic A signal (0 or 1) */ CHECK: Prefer kernel type 'u16' over 'uint16_t' #332: FILE: include/sound/sof/dai-intel.h:110: + uint16_t polarity_mic_b; /**< Optionally invert mic B signal (0 or 1) */ WARNING: please, no space before tabs #334: FILE: include/sound/sof/dai-intel.h:112: +^Iuint16_t clk_edge; ^I/**< Optionally swap data clock edge (0 or 1) */$ CHECK: Prefer kernel type 'u16' over 'uint16_t' #334: FILE: include/sound/sof/dai-intel.h:112: + uint16_t clk_edge; /**< Optionally swap data clock edge (0 or 1) */ WARNING: line over 80 characters #335: FILE: include/sound/sof/dai-intel.h:113: + uint16_t skew; /**< Adjust PDM data sampling vs. clock (0..15) */ WARNING: please, no space before tabs #335: FILE: include/sound/sof/dai-intel.h:113: +^Iuint16_t skew; ^I^I/**< Adjust PDM data sampling vs. clock (0..15) */$ CHECK: Prefer kernel type 'u16' over 'uint16_t' #335: FILE: include/sound/sof/dai-intel.h:113: + uint16_t skew; /**< Adjust PDM data sampling vs. clock (0..15) */ WARNING: line over 80 characters #337: FILE: include/sound/sof/dai-intel.h:115: + uint16_t reserved[3]; /**< Make sure the total size is 4 bytes aligned */ WARNING: please, no space before tabs #337: FILE: include/sound/sof/dai-intel.h:115: +^Iuint16_t reserved[3]; ^I/**< Make sure the total size is 4 bytes aligned */$ CHECK: Prefer kernel type 'u16' over 'uint16_t' #337: FILE: include/sound/sof/dai-intel.h:115: + uint16_t reserved[3]; /**< Make sure the total size is 4 bytes aligned */ WARNING: __packed is preferred over __attribute__((packed)) #338: FILE: include/sound/sof/dai-intel.h:116: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #362: FILE: include/sound/sof/dai-intel.h:140: + uint32_t driver_ipc_version; /**< Version (1..N) */ WARNING: line over 80 characters #364: FILE: include/sound/sof/dai-intel.h:142: + uint32_t pdmclk_min; /**< Minimum microphone clock in Hz (100000..N) */ WARNING: please, no space before tabs #364: FILE: include/sound/sof/dai-intel.h:142: +^Iuint32_t pdmclk_min; ^I/**< Minimum microphone clock in Hz (100000..N) */$ CHECK: Prefer kernel type 'u32' over 'uint32_t' #364: FILE: include/sound/sof/dai-intel.h:142: + uint32_t pdmclk_min; /**< Minimum microphone clock in Hz (100000..N) */ WARNING: please, no space before tabs #365: FILE: include/sound/sof/dai-intel.h:143: +^Iuint32_t pdmclk_max; ^I/**< Maximum microphone clock in Hz (min...N) */$ CHECK: Prefer kernel type 'u32' over 'uint32_t' #365: FILE: include/sound/sof/dai-intel.h:143: + uint32_t pdmclk_max; /**< Maximum microphone clock in Hz (min...N) */ WARNING: please, no space before tabs #367: FILE: include/sound/sof/dai-intel.h:145: +^Iuint32_t fifo_fs_a; ^I/**< FIFO A sample rate in Hz (8000..96000) */$ CHECK: Prefer kernel type 'u32' over 'uint32_t' #367: FILE: include/sound/sof/dai-intel.h:145: + uint32_t fifo_fs_a; /**< FIFO A sample rate in Hz (8000..96000) */ WARNING: please, no space before tabs #368: FILE: include/sound/sof/dai-intel.h:146: +^Iuint32_t fifo_fs_b; ^I/**< FIFO B sample rate in Hz (8000..96000) */$ CHECK: Prefer kernel type 'u32' over 'uint32_t' #368: FILE: include/sound/sof/dai-intel.h:146: + uint32_t fifo_fs_b; /**< FIFO B sample rate in Hz (8000..96000) */ WARNING: please, no space before tabs #369: FILE: include/sound/sof/dai-intel.h:147: +^Iuint16_t fifo_bits_a; ^I/**< FIFO A word length (16 or 32) */$ CHECK: Prefer kernel type 'u16' over 'uint16_t' #369: FILE: include/sound/sof/dai-intel.h:147: + uint16_t fifo_bits_a; /**< FIFO A word length (16 or 32) */ WARNING: please, no space before tabs #370: FILE: include/sound/sof/dai-intel.h:148: +^Iuint16_t fifo_bits_b; ^I/**< FIFO B word length (16 or 32) */$ CHECK: Prefer kernel type 'u16' over 'uint16_t' #370: FILE: include/sound/sof/dai-intel.h:148: + uint16_t fifo_bits_b; /**< FIFO B word length (16 or 32) */ WARNING: please, no space before tabs #372: FILE: include/sound/sof/dai-intel.h:150: +^Iuint16_t duty_min; ^I/**< Min. mic clock duty cycle in % (20..80) */$ CHECK: Prefer kernel type 'u16' over 'uint16_t' #372: FILE: include/sound/sof/dai-intel.h:150: + uint16_t duty_min; /**< Min. mic clock duty cycle in % (20..80) */ WARNING: please, no space before tabs #373: FILE: include/sound/sof/dai-intel.h:151: +^Iuint16_t duty_max; ^I/**< Max. mic clock duty cycle in % (min..80) */$ CHECK: Prefer kernel type 'u16' over 'uint16_t' #373: FILE: include/sound/sof/dai-intel.h:151: + uint16_t duty_max; /**< Max. mic clock duty cycle in % (min..80) */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #375: FILE: include/sound/sof/dai-intel.h:153: + uint32_t num_pdm_active; /**< Number of active pdm controllers */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #378: FILE: include/sound/sof/dai-intel.h:156: + uint32_t reserved[8]; WARNING: __packed is preferred over __attribute__((packed)) #382: FILE: include/sound/sof/dai-intel.h:160: +} __attribute__((packed)); CHECK: Please don't use multiple blank lines #384: FILE: include/sound/sof/dai-intel.h:162: + + WARNING: line over 80 characters #392: FILE: include/sound/sof/dai.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #394: FILE: include/sound/sof/dai.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or CHECK: Prefer using the BIT macro #419: FILE: include/sound/sof/dai.h:28: +#define SOF_DAI_FMT_CONT (1 << 4) /**< continuous clock */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #448: FILE: include/sound/sof/dai.h:57: + uint32_t type; /**< DAI type - enum sof_ipc_dai_type */ WARNING: please, no space before tabs #449: FILE: include/sound/sof/dai.h:58: +^Iuint32_t dai_index; ^I/**< index of this type dai */$ CHECK: Prefer kernel type 'u32' over 'uint32_t' #449: FILE: include/sound/sof/dai.h:58: + uint32_t dai_index; /**< index of this type dai */ CHECK: Prefer kernel type 'u16' over 'uint16_t' #452: FILE: include/sound/sof/dai.h:61: + uint16_t format; /**< SOF_DAI_FMT_ */ CHECK: Prefer kernel type 'u16' over 'uint16_t' #453: FILE: include/sound/sof/dai.h:62: + uint16_t reserved16; /**< alignment */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #456: FILE: include/sound/sof/dai.h:65: + uint32_t reserved[8]; WARNING: line over 80 characters #473: FILE: include/sound/sof/header.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #475: FILE: include/sound/sof/header.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or CHECK: Prefer using the BIT macro #603: FILE: include/sound/sof/header.h:131: +#define SOF_MEM_CAPS_RAM (1 << 0) CHECK: Prefer using the BIT macro #604: FILE: include/sound/sof/header.h:132: +#define SOF_MEM_CAPS_ROM (1 << 1) CHECK: Prefer using the BIT macro #605: FILE: include/sound/sof/header.h:133: +#define SOF_MEM_CAPS_EXT (1 << 2) /**< external */ CHECK: Prefer using the BIT macro #606: FILE: include/sound/sof/header.h:134: +#define SOF_MEM_CAPS_LP (1 << 3) /**< low power */ CHECK: Prefer using the BIT macro #607: FILE: include/sound/sof/header.h:135: +#define SOF_MEM_CAPS_HP (1 << 4) /**< high performance */ CHECK: Prefer using the BIT macro #608: FILE: include/sound/sof/header.h:136: +#define SOF_MEM_CAPS_DMA (1 << 5) /**< DMA'able */ CHECK: Prefer using the BIT macro #609: FILE: include/sound/sof/header.h:137: +#define SOF_MEM_CAPS_CACHE (1 << 6) /**< cacheable */ CHECK: Prefer using the BIT macro #610: FILE: include/sound/sof/header.h:138: +#define SOF_MEM_CAPS_EXEC (1 << 7) /**< executable */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #620: FILE: include/sound/sof/header.h:148: + uint32_t cmd; /**< SOF_IPC_GLB_ + cmd */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #621: FILE: include/sound/sof/header.h:149: + uint32_t size; /**< size of structure */ WARNING: __packed is preferred over __attribute__((packed)) #622: FILE: include/sound/sof/header.h:150: +} __attribute__((packed)); CHECK: Prefer kernel type 's32' over 'int32_t' #630: FILE: include/sound/sof/header.h:158: + int32_t error; /**< negative error numbers */ WARNING: __packed is preferred over __attribute__((packed)) #631: FILE: include/sound/sof/header.h:159: +} __attribute__((packed)); WARNING: line over 80 characters #644: FILE: include/sound/sof/header.h:172: + uint32_t count; /**< count of 0 means end of compound sequence */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #644: FILE: include/sound/sof/header.h:172: + uint32_t count; /**< count of 0 means end of compound sequence */ WARNING: __packed is preferred over __attribute__((packed)) #645: FILE: include/sound/sof/header.h:173: +} __attribute__((packed)); WARNING: line over 80 characters #656: FILE: include/sound/sof/info.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #658: FILE: include/sound/sof/info.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or CHECK: Prefer kernel type 'u16' over 'uint16_t' #684: FILE: include/sound/sof/info.h:29: + uint16_t major; CHECK: Prefer kernel type 'u16' over 'uint16_t' #685: FILE: include/sound/sof/info.h:30: + uint16_t minor; CHECK: Prefer kernel type 'u16' over 'uint16_t' #686: FILE: include/sound/sof/info.h:31: + uint16_t micro; CHECK: Prefer kernel type 'u16' over 'uint16_t' #687: FILE: include/sound/sof/info.h:32: + uint16_t build; CHECK: Prefer kernel type 'u8' over 'uint8_t' #688: FILE: include/sound/sof/info.h:33: + uint8_t date[12]; CHECK: Prefer kernel type 'u8' over 'uint8_t' #689: FILE: include/sound/sof/info.h:34: + uint8_t time[10]; CHECK: Prefer kernel type 'u8' over 'uint8_t' #690: FILE: include/sound/sof/info.h:35: + uint8_t tag[6]; CHECK: Prefer kernel type 'u32' over 'uint32_t' #691: FILE: include/sound/sof/info.h:36: + uint32_t abi_version; CHECK: Prefer kernel type 'u32' over 'uint32_t' #694: FILE: include/sound/sof/info.h:39: + uint32_t reserved[4]; WARNING: __packed is preferred over __attribute__((packed)) #695: FILE: include/sound/sof/info.h:40: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #700: FILE: include/sound/sof/info.h:45: + uint32_t dspbox_offset; /* dsp initiated IPC mailbox */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #701: FILE: include/sound/sof/info.h:46: + uint32_t hostbox_offset; /* host initiated IPC mailbox */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #702: FILE: include/sound/sof/info.h:47: + uint32_t dspbox_size; CHECK: Prefer kernel type 'u32' over 'uint32_t' #703: FILE: include/sound/sof/info.h:48: + uint32_t hostbox_size; CHECK: Prefer kernel type 'u64' over 'uint64_t' #708: FILE: include/sound/sof/info.h:53: + uint64_t reserved; CHECK: Prefer kernel type 'u32' over 'uint32_t' #715: FILE: include/sound/sof/info.h:60: + uint32_t reserved[4]; WARNING: __packed is preferred over __attribute__((packed)) #716: FILE: include/sound/sof/info.h:61: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #733: FILE: include/sound/sof/info.h:78: + uint32_t type; /**< SOF_IPC_EXT_ */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #737: FILE: include/sound/sof/info.h:82: + uint32_t type; /**< SOF_IPC_REGION_ */ WARNING: line over 80 characters #738: FILE: include/sound/sof/info.h:83: + uint32_t id; /**< platform specific - used to map to host memory */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #738: FILE: include/sound/sof/info.h:83: + uint32_t id; /**< platform specific - used to map to host memory */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #745: FILE: include/sound/sof/info.h:90: + uint32_t num_buffers; WARNING: __packed is preferred over __attribute__((packed)) #749: FILE: include/sound/sof/info.h:94: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #752: FILE: include/sound/sof/info.h:97: + uint32_t type; /**< SOF_IPC_REGION_ */ WARNING: line over 80 characters #753: FILE: include/sound/sof/info.h:98: + uint32_t id; /**< platform specific - used to map to host memory */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #753: FILE: include/sound/sof/info.h:98: + uint32_t id; /**< platform specific - used to map to host memory */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #754: FILE: include/sound/sof/info.h:99: + uint32_t flags; /**< R, W, RW, etc - to define */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #755: FILE: include/sound/sof/info.h:100: + uint32_t size; /**< size of region in bytes */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #757: FILE: include/sound/sof/info.h:102: + uint32_t offset; CHECK: Prefer kernel type 'u32' over 'uint32_t' #763: FILE: include/sound/sof/info.h:108: + uint32_t num_windows; WARNING: __packed is preferred over __attribute__((packed)) #765: FILE: include/sound/sof/info.h:110: +} __attribute__((packed)); WARNING: line over 80 characters #774: FILE: include/sound/sof/pm.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #776: FILE: include/sound/sof/pm.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or CHECK: Prefer kernel type 'u32' over 'uint32_t' #793: FILE: include/sound/sof/pm.h:20: + uint32_t type; CHECK: Prefer kernel type 'u32' over 'uint32_t' #794: FILE: include/sound/sof/pm.h:21: + uint32_t size; CHECK: Prefer kernel type 'u64' over 'uint64_t' #795: FILE: include/sound/sof/pm.h:22: + uint64_t addr; WARNING: __packed is preferred over __attribute__((packed)) #796: FILE: include/sound/sof/pm.h:23: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #805: FILE: include/sound/sof/pm.h:32: + uint32_t num_elems; CHECK: Prefer kernel type 'u32' over 'uint32_t' #806: FILE: include/sound/sof/pm.h:33: + uint32_t size; CHECK: Prefer kernel type 'u32' over 'uint32_t' #809: FILE: include/sound/sof/pm.h:36: + uint32_t reserved[8]; CHECK: Prefer kernel type 'u32' over 'uint32_t' #817: FILE: include/sound/sof/pm.h:44: + uint32_t enable_mask; CHECK: Please don't use multiple blank lines #820: FILE: include/sound/sof/pm.h:47: + + WARNING: line over 80 characters #828: FILE: include/sound/sof/stream.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #830: FILE: include/sound/sof/stream.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or CHECK: Prefer using the BIT macro #848: FILE: include/sound/sof/stream.h:21: +#define SOF_RATE_8000 (1 << 0) /**< 8000Hz */ CHECK: Prefer using the BIT macro #849: FILE: include/sound/sof/stream.h:22: +#define SOF_RATE_11025 (1 << 1) /**< 11025Hz */ CHECK: Prefer using the BIT macro #850: FILE: include/sound/sof/stream.h:23: +#define SOF_RATE_12000 (1 << 2) /**< 12000Hz */ CHECK: Prefer using the BIT macro #851: FILE: include/sound/sof/stream.h:24: +#define SOF_RATE_16000 (1 << 3) /**< 16000Hz */ CHECK: Prefer using the BIT macro #852: FILE: include/sound/sof/stream.h:25: +#define SOF_RATE_22050 (1 << 4) /**< 22050Hz */ CHECK: Prefer using the BIT macro #853: FILE: include/sound/sof/stream.h:26: +#define SOF_RATE_24000 (1 << 5) /**< 24000Hz */ CHECK: Prefer using the BIT macro #854: FILE: include/sound/sof/stream.h:27: +#define SOF_RATE_32000 (1 << 6) /**< 32000Hz */ CHECK: Prefer using the BIT macro #855: FILE: include/sound/sof/stream.h:28: +#define SOF_RATE_44100 (1 << 7) /**< 44100Hz */ CHECK: Prefer using the BIT macro #856: FILE: include/sound/sof/stream.h:29: +#define SOF_RATE_48000 (1 << 8) /**< 48000Hz */ CHECK: Prefer using the BIT macro #857: FILE: include/sound/sof/stream.h:30: +#define SOF_RATE_64000 (1 << 9) /**< 64000Hz */ CHECK: Prefer using the BIT macro #858: FILE: include/sound/sof/stream.h:31: +#define SOF_RATE_88200 (1 << 10) /**< 88200Hz */ CHECK: Prefer using the BIT macro #859: FILE: include/sound/sof/stream.h:32: +#define SOF_RATE_96000 (1 << 11) /**< 96000Hz */ CHECK: Prefer using the BIT macro #860: FILE: include/sound/sof/stream.h:33: +#define SOF_RATE_176400 (1 << 12) /**< 176400Hz */ CHECK: Prefer using the BIT macro #861: FILE: include/sound/sof/stream.h:34: +#define SOF_RATE_192000 (1 << 13) /**< 192000Hz */ CHECK: Prefer using the BIT macro #864: FILE: include/sound/sof/stream.h:37: +#define SOF_RATE_CONTINUOUS (1 << 30) /**< range */ CHECK: Prefer using the BIT macro #865: FILE: include/sound/sof/stream.h:38: +#define SOF_RATE_KNOT (1 << 31) /**< non-continuous */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #891: FILE: include/sound/sof/stream.h:64: + uint32_t phy_addr; CHECK: Prefer kernel type 'u32' over 'uint32_t' #892: FILE: include/sound/sof/stream.h:65: + uint32_t pages; CHECK: Prefer kernel type 'u32' over 'uint32_t' #893: FILE: include/sound/sof/stream.h:66: + uint32_t size; CHECK: Prefer kernel type 'u32' over 'uint32_t' #894: FILE: include/sound/sof/stream.h:67: + uint32_t offset; WARNING: __packed is preferred over __attribute__((packed)) #895: FILE: include/sound/sof/stream.h:68: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #899: FILE: include/sound/sof/stream.h:72: + uint32_t direction; /**< enum sof_ipc_stream_directio */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #900: FILE: include/sound/sof/stream.h:73: + uint32_t frame_fmt; /**< enum sof_ipc_frame */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #901: FILE: include/sound/sof/stream.h:74: + uint32_t buffer_fmt; /**< enum sof_ipc_buffer_format */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #902: FILE: include/sound/sof/stream.h:75: + uint32_t rate; CHECK: Prefer kernel type 'u16' over 'uint16_t' #903: FILE: include/sound/sof/stream.h:76: + uint16_t stream_tag; CHECK: Prefer kernel type 'u16' over 'uint16_t' #904: FILE: include/sound/sof/stream.h:77: + uint16_t channels; CHECK: Prefer kernel type 'u16' over 'uint16_t' #905: FILE: include/sound/sof/stream.h:78: + uint16_t sample_valid_bytes; CHECK: Prefer kernel type 'u16' over 'uint16_t' #906: FILE: include/sound/sof/stream.h:79: + uint16_t sample_container_bytes; CHECK: Prefer kernel type 'u32' over 'uint32_t' #909: FILE: include/sound/sof/stream.h:82: + uint32_t host_period_bytes; CHECK: Prefer kernel type 'u16' over 'uint16_t' #911: FILE: include/sound/sof/stream.h:84: + uint16_t chmap[SOF_IPC_MAX_CHANNELS]; /**< channel map - SOF_CHMAP_ */ WARNING: __packed is preferred over __attribute__((packed)) #912: FILE: include/sound/sof/stream.h:85: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #917: FILE: include/sound/sof/stream.h:90: + uint32_t comp_id; WARNING: __packed is preferred over __attribute__((packed)) #919: FILE: include/sound/sof/stream.h:92: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #924: FILE: include/sound/sof/stream.h:97: + uint32_t comp_id; CHECK: Prefer kernel type 'u32' over 'uint32_t' #925: FILE: include/sound/sof/stream.h:98: + uint32_t posn_offset; WARNING: __packed is preferred over __attribute__((packed)) #926: FILE: include/sound/sof/stream.h:99: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #931: FILE: include/sound/sof/stream.h:104: + uint32_t comp_id; WARNING: __packed is preferred over __attribute__((packed)) #932: FILE: include/sound/sof/stream.h:105: +} __attribute__((packed)); CHECK: Prefer using the BIT macro #935: FILE: include/sound/sof/stream.h:108: +#define SOF_TIME_HOST_SYNC (1 << 0) CHECK: Prefer using the BIT macro #936: FILE: include/sound/sof/stream.h:109: +#define SOF_TIME_DAI_SYNC (1 << 1) CHECK: Prefer using the BIT macro #937: FILE: include/sound/sof/stream.h:110: +#define SOF_TIME_WALL_SYNC (1 << 2) CHECK: Prefer using the BIT macro #938: FILE: include/sound/sof/stream.h:111: +#define SOF_TIME_STAMP_SYNC (1 << 3) CHECK: Prefer using the BIT macro #941: FILE: include/sound/sof/stream.h:114: +#define SOF_TIME_HOST_VALID (1 << 8) CHECK: Prefer using the BIT macro #942: FILE: include/sound/sof/stream.h:115: +#define SOF_TIME_DAI_VALID (1 << 9) CHECK: Prefer using the BIT macro #943: FILE: include/sound/sof/stream.h:116: +#define SOF_TIME_WALL_VALID (1 << 10) CHECK: Prefer using the BIT macro #944: FILE: include/sound/sof/stream.h:117: +#define SOF_TIME_STAMP_VALID (1 << 11) CHECK: Prefer using the BIT macro #947: FILE: include/sound/sof/stream.h:120: +#define SOF_TIME_HOST_64 (1 << 16) CHECK: Prefer using the BIT macro #948: FILE: include/sound/sof/stream.h:121: +#define SOF_TIME_DAI_64 (1 << 17) CHECK: Prefer using the BIT macro #949: FILE: include/sound/sof/stream.h:122: +#define SOF_TIME_WALL_64 (1 << 18) CHECK: Prefer using the BIT macro #950: FILE: include/sound/sof/stream.h:123: +#define SOF_TIME_STAMP_64 (1 << 19) CHECK: Prefer kernel type 'u32' over 'uint32_t' #954: FILE: include/sound/sof/stream.h:127: + uint32_t comp_id; /**< host component ID */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #955: FILE: include/sound/sof/stream.h:128: + uint32_t flags; /**< SOF_TIME_ */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #956: FILE: include/sound/sof/stream.h:129: + uint32_t wallclock_hz; /**< frequency of wallclock in Hz */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #957: FILE: include/sound/sof/stream.h:130: + uint32_t timestamp_ns; /**< resolution of timestamp in ns */ CHECK: Prefer kernel type 'u64' over 'uint64_t' #958: FILE: include/sound/sof/stream.h:131: + uint64_t host_posn; /**< host DMA position in bytes */ CHECK: Prefer kernel type 'u64' over 'uint64_t' #959: FILE: include/sound/sof/stream.h:132: + uint64_t dai_posn; /**< DAI DMA position in bytes */ CHECK: Prefer kernel type 'u64' over 'uint64_t' #960: FILE: include/sound/sof/stream.h:133: + uint64_t comp_posn; /**< comp position in bytes */ CHECK: Prefer kernel type 'u64' over 'uint64_t' #961: FILE: include/sound/sof/stream.h:134: + uint64_t wallclock; /**< audio wall clock */ CHECK: Prefer kernel type 'u64' over 'uint64_t' #962: FILE: include/sound/sof/stream.h:135: + uint64_t timestamp; /**< system time stamp */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #963: FILE: include/sound/sof/stream.h:136: + uint32_t xrun_comp_id; /**< comp ID of XRUN component */ CHECK: Prefer kernel type 's32' over 'int32_t' #964: FILE: include/sound/sof/stream.h:137: + int32_t xrun_size; /**< XRUN size in bytes */ WARNING: __packed is preferred over __attribute__((packed)) #965: FILE: include/sound/sof/stream.h:138: +} __attribute__((packed)); WARNING: line over 80 characters #974: FILE: include/sound/sof/topology.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #976: FILE: include/sound/sof/topology.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or CHECK: Prefer kernel type 'u32' over 'uint32_t' #1020: FILE: include/sound/sof/topology.h:47: + uint32_t id; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1022: FILE: include/sound/sof/topology.h:49: + uint32_t pipeline_id; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1025: FILE: include/sound/sof/topology.h:52: + uint32_t reserved[2]; WARNING: __packed is preferred over __attribute__((packed)) #1026: FILE: include/sound/sof/topology.h:53: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1035: FILE: include/sound/sof/topology.h:62: + uint32_t size; /**< buffer size in bytes */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1036: FILE: include/sound/sof/topology.h:63: + uint32_t caps; /**< SOF_MEM_CAPS_ */ WARNING: __packed is preferred over __attribute__((packed)) #1037: FILE: include/sound/sof/topology.h:64: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1041: FILE: include/sound/sof/topology.h:68: + uint32_t periods_sink; /**< 0 means variable */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1042: FILE: include/sound/sof/topology.h:69: + uint32_t periods_source; /**< 0 means variable */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1043: FILE: include/sound/sof/topology.h:70: + uint32_t preload_count; /**< how many periods to preload */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1044: FILE: include/sound/sof/topology.h:71: + uint32_t frame_fmt; /**< SOF_IPC_FRAME_ */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1045: FILE: include/sound/sof/topology.h:72: + uint32_t xrun_action; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1048: FILE: include/sound/sof/topology.h:75: + uint32_t reserved[2]; WARNING: __packed is preferred over __attribute__((packed)) #1049: FILE: include/sound/sof/topology.h:76: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1055: FILE: include/sound/sof/topology.h:82: + uint32_t direction; /**< SOF_IPC_STREAM_ */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1056: FILE: include/sound/sof/topology.h:83: + uint32_t no_irq; /**< don't send periodic IRQ to host/DSP */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1057: FILE: include/sound/sof/topology.h:84: + uint32_t dmac_config; /**< DMA engine specific */ WARNING: __packed is preferred over __attribute__((packed)) #1058: FILE: include/sound/sof/topology.h:85: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1064: FILE: include/sound/sof/topology.h:91: + uint32_t direction; /**< SOF_IPC_STREAM_ */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1065: FILE: include/sound/sof/topology.h:92: + uint32_t dai_index; /**< index of this type dai */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1066: FILE: include/sound/sof/topology.h:93: + uint32_t type; /**< DAI type - SOF_DAI_ */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1067: FILE: include/sound/sof/topology.h:94: + uint32_t dmac_config; /**< DMA engine specific */ WARNING: __packed is preferred over __attribute__((packed)) #1068: FILE: include/sound/sof/topology.h:95: +} __attribute__((packed)); WARNING: __packed is preferred over __attribute__((packed)) #1074: FILE: include/sound/sof/topology.h:101: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1088: FILE: include/sound/sof/topology.h:115: + uint32_t channels; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1089: FILE: include/sound/sof/topology.h:116: + uint32_t min_value; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1090: FILE: include/sound/sof/topology.h:117: + uint32_t max_value; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1091: FILE: include/sound/sof/topology.h:118: + uint32_t ramp; /**< SOF_VOLUME_ */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1092: FILE: include/sound/sof/topology.h:119: + uint32_t initial_ramp; /**< ramp space in ms */ WARNING: __packed is preferred over __attribute__((packed)) #1093: FILE: include/sound/sof/topology.h:120: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1100: FILE: include/sound/sof/topology.h:127: + uint32_t source_rate; /**< source rate or 0 for variable */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1101: FILE: include/sound/sof/topology.h:128: + uint32_t sink_rate; /**< sink rate or 0 for variable */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1102: FILE: include/sound/sof/topology.h:129: + uint32_t rate_mask; /**< SOF_RATE_ supported rates */ WARNING: __packed is preferred over __attribute__((packed)) #1103: FILE: include/sound/sof/topology.h:130: +} __attribute__((packed)); WARNING: __packed is preferred over __attribute__((packed)) #1109: FILE: include/sound/sof/topology.h:136: +} __attribute__((packed)); CHECK: Prefer kernel type 's32' over 'int32_t' #1115: FILE: include/sound/sof/topology.h:142: + int32_t sample_rate; CHECK: Prefer kernel type 's32' over 'int32_t' #1116: FILE: include/sound/sof/topology.h:143: + int32_t frequency; CHECK: Prefer kernel type 's32' over 'int32_t' #1117: FILE: include/sound/sof/topology.h:144: + int32_t amplitude; CHECK: Prefer kernel type 's32' over 'int32_t' #1118: FILE: include/sound/sof/topology.h:145: + int32_t freq_mult; CHECK: Prefer kernel type 's32' over 'int32_t' #1119: FILE: include/sound/sof/topology.h:146: + int32_t ampl_mult; CHECK: Prefer kernel type 's32' over 'int32_t' #1120: FILE: include/sound/sof/topology.h:147: + int32_t length; CHECK: Prefer kernel type 's32' over 'int32_t' #1121: FILE: include/sound/sof/topology.h:148: + int32_t period; CHECK: Prefer kernel type 's32' over 'int32_t' #1122: FILE: include/sound/sof/topology.h:149: + int32_t repeats; CHECK: Prefer kernel type 's32' over 'int32_t' #1123: FILE: include/sound/sof/topology.h:150: + int32_t ramp_step; WARNING: __packed is preferred over __attribute__((packed)) #1124: FILE: include/sound/sof/topology.h:151: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1135: FILE: include/sound/sof/topology.h:162: + uint32_t type; /** sof_ipc_effect_type */ WARNING: __packed is preferred over __attribute__((packed)) #1136: FILE: include/sound/sof/topology.h:163: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1142: FILE: include/sound/sof/topology.h:169: + uint32_t size; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1145: FILE: include/sound/sof/topology.h:172: + uint32_t reserved[8]; WARNING: __packed is preferred over __attribute__((packed)) #1148: FILE: include/sound/sof/topology.h:175: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1154: FILE: include/sound/sof/topology.h:181: + uint32_t size; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1157: FILE: include/sound/sof/topology.h:184: + uint32_t reserved[8]; WARNING: __packed is preferred over __attribute__((packed)) #1160: FILE: include/sound/sof/topology.h:187: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1167: FILE: include/sound/sof/topology.h:194: + uint32_t id; WARNING: __packed is preferred over __attribute__((packed)) #1168: FILE: include/sound/sof/topology.h:195: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1172: FILE: include/sound/sof/topology.h:199: + uint32_t id; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1173: FILE: include/sound/sof/topology.h:200: + uint32_t offset; WARNING: __packed is preferred over __attribute__((packed)) #1174: FILE: include/sound/sof/topology.h:201: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1183: FILE: include/sound/sof/topology.h:210: + uint32_t comp_id; /**< component id for pipeline */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1184: FILE: include/sound/sof/topology.h:211: + uint32_t pipeline_id; /**< pipeline id */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1185: FILE: include/sound/sof/topology.h:212: + uint32_t sched_id; /**< sheduling component id */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1186: FILE: include/sound/sof/topology.h:213: + uint32_t core; /**< core we run on */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1187: FILE: include/sound/sof/topology.h:214: + uint32_t deadline; /**< execution completion deadline in us*/ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1188: FILE: include/sound/sof/topology.h:215: + uint32_t priority; /**< priority level 0 (low) to 10 (max) */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1189: FILE: include/sound/sof/topology.h:216: + uint32_t period_mips; /**< worst case instruction count per period */ WARNING: line over 80 characters #1190: FILE: include/sound/sof/topology.h:217: + uint32_t frames_per_sched;/**< output frames of pipeline, 0 is variable */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1190: FILE: include/sound/sof/topology.h:217: + uint32_t frames_per_sched;/**< output frames of pipeline, 0 is variable */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1191: FILE: include/sound/sof/topology.h:218: + uint32_t xrun_limit_usecs; /**< report xruns greater than limit */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1194: FILE: include/sound/sof/topology.h:221: + uint32_t timer_delay; WARNING: __packed is preferred over __attribute__((packed)) #1195: FILE: include/sound/sof/topology.h:222: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1200: FILE: include/sound/sof/topology.h:227: + uint32_t comp_id; WARNING: __packed is preferred over __attribute__((packed)) #1201: FILE: include/sound/sof/topology.h:228: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1205: FILE: include/sound/sof/topology.h:232: + uint32_t comp_id; WARNING: __packed is preferred over __attribute__((packed)) #1206: FILE: include/sound/sof/topology.h:233: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1211: FILE: include/sound/sof/topology.h:238: + uint32_t source_id; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1212: FILE: include/sound/sof/topology.h:239: + uint32_t sink_id; WARNING: __packed is preferred over __attribute__((packed)) #1213: FILE: include/sound/sof/topology.h:240: +} __attribute__((packed)); CHECK: Please don't use multiple blank lines #1215: FILE: include/sound/sof/topology.h:242: + + WARNING: line over 80 characters #1223: FILE: include/sound/sof/trace.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #1225: FILE: include/sound/sof/trace.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or CHECK: Prefer kernel type 'u32' over 'uint32_t' #1247: FILE: include/sound/sof/trace.h:25: + uint32_t stream_tag; WARNING: __packed is preferred over __attribute__((packed)) #1248: FILE: include/sound/sof/trace.h:26: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1253: FILE: include/sound/sof/trace.h:31: + uint32_t host_offset; /* Offset of DMA host buffer */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1254: FILE: include/sound/sof/trace.h:32: + uint32_t overflow; /* overflow bytes if any */ CHECK: Prefer kernel type 'u32' over 'uint32_t' #1255: FILE: include/sound/sof/trace.h:33: + uint32_t messages; /* total trace messages */ WARNING: __packed is preferred over __attribute__((packed)) #1256: FILE: include/sound/sof/trace.h:34: +} __attribute__((packed)); CHECK: Prefer kernel type 'u32' over 'uint32_t' #1265: FILE: include/sound/sof/trace.h:43: + uint32_t linenum; WARNING: __packed is preferred over __attribute__((packed)) #1266: FILE: include/sound/sof/trace.h:44: +} __attribute__((packed)); WARNING: line over 80 characters #1275: FILE: include/sound/sof/xtensa.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #1277: FILE: include/sound/sof/xtensa.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or CHECK: Prefer kernel type 'u32' over 'uint32_t' #1292: FILE: include/sound/sof/xtensa.h:18: + uint32_t exccause; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1293: FILE: include/sound/sof/xtensa.h:19: + uint32_t excvaddr; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1294: FILE: include/sound/sof/xtensa.h:20: + uint32_t ps; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1295: FILE: include/sound/sof/xtensa.h:21: + uint32_t epc1; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1296: FILE: include/sound/sof/xtensa.h:22: + uint32_t epc2; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1297: FILE: include/sound/sof/xtensa.h:23: + uint32_t epc3; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1298: FILE: include/sound/sof/xtensa.h:24: + uint32_t epc4; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1299: FILE: include/sound/sof/xtensa.h:25: + uint32_t epc5; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1300: FILE: include/sound/sof/xtensa.h:26: + uint32_t epc6; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1301: FILE: include/sound/sof/xtensa.h:27: + uint32_t epc7; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1302: FILE: include/sound/sof/xtensa.h:28: + uint32_t eps2; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1303: FILE: include/sound/sof/xtensa.h:29: + uint32_t eps3; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1304: FILE: include/sound/sof/xtensa.h:30: + uint32_t eps4; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1305: FILE: include/sound/sof/xtensa.h:31: + uint32_t eps5; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1306: FILE: include/sound/sof/xtensa.h:32: + uint32_t eps6; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1307: FILE: include/sound/sof/xtensa.h:33: + uint32_t eps7; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1308: FILE: include/sound/sof/xtensa.h:34: + uint32_t depc; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1309: FILE: include/sound/sof/xtensa.h:35: + uint32_t intenable; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1310: FILE: include/sound/sof/xtensa.h:36: + uint32_t interrupt; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1311: FILE: include/sound/sof/xtensa.h:37: + uint32_t sar; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1312: FILE: include/sound/sof/xtensa.h:38: + uint32_t stack; WARNING: __packed is preferred over __attribute__((packed)) #1313: FILE: include/sound/sof/xtensa.h:39: +} __attribute__((packed)); WARNING: line over 80 characters #2375: FILE: include/uapi/sound/sof/abi.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #2377: FILE: include/uapi/sound/sof/abi.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or WARNING: line over 80 characters #2554: FILE: include/uapi/sound/sof/header.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #2556: FILE: include/uapi/sound/sof/header.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or WARNING: line over 80 characters #2587: FILE: include/uapi/sound/sof/manifest.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #2589: FILE: include/uapi/sound/sof/manifest.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or CHECK: Please don't use multiple blank lines #2689: FILE: include/uapi/sound/sof/manifest.h:103: + + WARNING: line over 80 characters #2721: FILE: include/uapi/sound/sof/manifest.h:135: + /* target address for binary loading as offset in IMR - must be == base offset */ CHECK: Lines should not end with a '(' #2783: FILE: include/uapi/sound/sof/manifest.h:197: +static inline struct sof_man_module *sof_man_get_module( WARNING: line over 80 characters #2836: FILE: include/uapi/sound/sof/trace.h:1: +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note)) OR BSD-3-Clause) */ WARNING: Block comments should align the * on each line #2838: FILE: include/uapi/sound/sof/trace.h:3: +/* +* This file is provided under a dual BSD/GPLv2 license. When using or WARNING: Block comments should align the * on each line #2914: FILE: include/uapi/sound/sof/trace.h:79: +/* +* Log entry header. WARNING: line over 80 characters #3180: FILE: sound/soc/sof/topology.c:1121: + pipeline->period_mips, pipeline->core, pipeline->frames_per_sched); total: 0 errors, 102 warnings, 248 checks, 1869 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./linux-sof-driver/0001-ASoC-SOF-ABI-Split-ABI-headers-and-update-to-latest-.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.