ERROR: do not set execute permissions for source files #34: FILE: include/sound/sof.h ERROR: do not set execute permissions for source files #60: FILE: include/uapi/sound/sof-ipc.h WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #103: new file mode 100644 WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #108: FILE: include/uapi/sound/sof-virtio.h:1: +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) ERROR: do not set execute permissions for source files #138: FILE: sound/soc/sof/Kconfig ERROR: do not set execute permissions for source files #171: FILE: sound/soc/sof/Makefile ERROR: do not set execute permissions for source files #193: FILE: sound/soc/sof/core.c ERROR: trailing whitespace #234: FILE: sound/soc/sof/core.c:329: +#if !IS_ENABLED(CONFIG_SND_SOC_SOF_VIRTIO_FE)^I$ ERROR: do not set execute permissions for source files #265: FILE: sound/soc/sof/sof-priv.h CHECK: Please don't use multiple blank lines #277: FILE: sound/soc/sof/sof-priv.h:29: + ERROR: trailing whitespace #289: FILE: sound/soc/sof/sof-priv.h:41: +// and later ACRN will use vhost to replace vbs. So this should be put $ WARNING: 'offical' may be misspelled - perhaps 'official'? #291: FILE: sound/soc/sof/sof-priv.h:43: +// I will submit a email to get the offical answer from ACRN team. CHECK: Please don't use multiple blank lines #328: FILE: sound/soc/sof/sof-priv.h:317: + WARNING: please, no space before tabs #358: FILE: sound/soc/sof/sof-priv.h:347: +^Iint ^I vmid;$ CHECK: spinlock_t definition without comment #387: FILE: sound/soc/sof/sof-priv.h:376: + spinlock_t posn_lock; CHECK: Please use a blank line after function/struct/union/enum declarations #394: FILE: sound/soc/sof/sof-priv.h:383: +}; +void *get_sof_dev(void); CHECK: Please don't use multiple blank lines #399: FILE: sound/soc/sof/sof-priv.h:388: + + WARNING: line over 80 characters #467: FILE: sound/soc/sof/sof-priv.h:621: +int sof_virtio_submit_guest_ipc(struct snd_sof_dev *sdev, int vm_id, void *ipc_buf, WARNING: line over 80 characters #468: FILE: sound/soc/sof/sof-priv.h:622: + void *reply_buf, size_t count, size_t reply_sz); CHECK: Alignment should match open parenthesis #468: FILE: sound/soc/sof/sof-priv.h:622: +int sof_virtio_submit_guest_ipc(struct snd_sof_dev *sdev, int vm_id, void *ipc_buf, + void *reply_buf, size_t count, size_t reply_sz); WARNING: line over 80 characters #473: FILE: sound/soc/sof/sof-priv.h:627: + struct sof_ipc_stream_posn *posn); CHECK: Alignment should match open parenthesis #473: FILE: sound/soc/sof/sof-priv.h:627: +int sof_virtio_try_update_guest_posn(struct snd_sof_dev *sdev, + struct sof_ipc_stream_posn *posn); WARNING: line over 80 characters #474: FILE: sound/soc/sof/sof-priv.h:628: +//int sof_virtio_try_update_guest_posn(struct snd_sof_dev *sdev, bool *is_guest); ERROR: do not set execute permissions for source files #489: FILE: sound/soc/sof/virtio-be.c CHECK: Please don't use multiple blank lines #548: FILE: sound/soc/sof/virtio-be.c:37: + + WARNING: line over 80 characters #549: FILE: sound/soc/sof/virtio-be.c:38: +// FIXME: most of the macros and func declarations below can be found in the headers CHECK: Avoid CamelCase: #550: FILE: sound/soc/sof/virtio-be.c:39: +#define iGS(x) ((x >> SOF_GLB_TYPE_SHIFT) & 0xf) CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues #550: FILE: sound/soc/sof/virtio-be.c:39: +#define iGS(x) ((x >> SOF_GLB_TYPE_SHIFT) & 0xf) CHECK: Avoid CamelCase: #551: FILE: sound/soc/sof/virtio-be.c:40: +#define iCS(x) ((x >> SOF_CMD_TYPE_SHIFT) & 0xfff) CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues #551: FILE: sound/soc/sof/virtio-be.c:40: +#define iCS(x) ((x >> SOF_CMD_TYPE_SHIFT) & 0xfff) CHECK: Please don't use multiple blank lines #553: FILE: sound/soc/sof/virtio-be.c:42: + + WARNING: line over 80 characters #555: FILE: sound/soc/sof/virtio-be.c:44: + void *reply_data, size_t count, size_t reply_size) WARNING: line over 80 characters #625: FILE: sound/soc/sof/virtio-be.c:98: + struct snd_soc_pcm_runtime *rtd, CHECK: Comparison to NULL could be written "!pcm" #637: FILE: sound/soc/sof/virtio-be.c:110: + if (pcm == NULL) CHECK: Comparison to NULL could be written "!stream" #641: FILE: sound/soc/sof/virtio-be.c:114: + if (stream == NULL) CHECK: Prefer kernel type 'u32' over 'uint32_t' #674: FILE: sound/soc/sof/virtio-be.c:145: + uint32_t comp_id; CHECK: Comparison to NULL could be written "!runtime" #689: FILE: sound/soc/sof/virtio-be.c:160: + if (runtime == NULL) CHECK: Comparison to NULL could be written "!runtime->status" #693: FILE: sound/soc/sof/virtio-be.c:164: + if (runtime->status == NULL) { ERROR: "(foo*)" should be "(foo *)" #697: FILE: sound/soc/sof/virtio-be.c:168: + memset((void*)runtime->status, 0, size); CHECK: Comparison to NULL could be written "!runtime->control" #701: FILE: sound/soc/sof/virtio-be.c:172: + if (runtime->control == NULL) { ERROR: "(foo*)" should be "(foo *)" #702: FILE: sound/soc/sof/virtio-be.c:173: + snd_free_pages((void*)runtime->status, WARNING: line over 80 characters #703: FILE: sound/soc/sof/virtio-be.c:174: + PAGE_ALIGN(sizeof(struct snd_pcm_mmap_status))); CHECK: Alignment should match open parenthesis #703: FILE: sound/soc/sof/virtio-be.c:174: + snd_free_pages((void*)runtime->status, + PAGE_ALIGN(sizeof(struct snd_pcm_mmap_status))); ERROR: "(foo*)" should be "(foo *)" #707: FILE: sound/soc/sof/virtio-be.c:178: + memset((void*)runtime->control, 0, size); CHECK: Alignment should match open parenthesis #730: FILE: sound/soc/sof/virtio-be.c:200: +static int sbe_pcm_close(struct snd_sof_dev *sdev, + void *ipc_data, int vm_id) CHECK: Prefer kernel type 'u32' over 'uint32_t' #739: FILE: sound/soc/sof/virtio-be.c:207: + uint32_t comp_id; ERROR: "(foo*)" should be "(foo *)" #761: FILE: sound/soc/sof/virtio-be.c:227: + snd_free_pages((void*)runtime->status, ERROR: "(foo*)" should be "(foo *)" #763: FILE: sound/soc/sof/virtio-be.c:229: + snd_free_pages((void*)runtime->control, ERROR: trailing whitespace #774: FILE: sound/soc/sof/virtio-be.c:239: +// FIXME - this function should only convert a compressed GOS PHY page table into $ WARNING: line over 80 characters #774: FILE: sound/soc/sof/virtio-be.c:239: +// FIXME - this function should only convert a compressed GOS PHY page table into CHECK: Prefer kernel type 'u8' over 'uint8_t' #784: FILE: sound/soc/sof/virtio-be.c:248: + uint8_t *page_table = (uint8_t *)__va(pcm_buffer_hpa); CHECK: Prefer kernel type 'u32' over 'uint32_t' #786: FILE: sound/soc/sof/virtio-be.c:250: + uint32_t gpa_parse, pages; CHECK: Prefer kernel type 'u32' over 'uint32_t' #869: FILE: sound/soc/sof/virtio-be.c:327: + uint32_t gpa_parse, pages; CHECK: Please don't use multiple blank lines #872: FILE: sound/soc/sof/virtio-be.c:330: + + WARNING: Prefer kcalloc over kzalloc with multiply #882: FILE: sound/soc/sof/virtio-be.c:340: + table = kzalloc(sizeof(*table) * pages, GFP_KERNEL); CHECK: Please don't use multiple blank lines #890: FILE: sound/soc/sof/virtio-be.c:348: + + ERROR: "(foo*)" should be "(foo *)" #939: FILE: sound/soc/sof/virtio-be.c:387: + pcm = (struct sof_ipc_pcm_params*)hdr; ERROR: space required before the open parenthesis '(' #997: FILE: sound/soc/sof/virtio-be.c:433: + switch(comp->type) { WARNING: line over 80 characters #1009: FILE: sound/soc/sof/virtio-be.c:445: + spcm->stream[SNDRV_PCM_STREAM_PLAYBACK].comp_id = COMP_ID_UNASSIGNED; WARNING: line over 80 characters #1010: FILE: sound/soc/sof/virtio-be.c:446: + spcm->stream[SNDRV_PCM_STREAM_CAPTURE].comp_id = COMP_ID_UNASSIGNED; CHECK: Prefer kernel type 'u32' over 'uint32_t' #1034: FILE: sound/soc/sof/virtio-be.c:465: + uint32_t cmd; CHECK: Alignment should match open parenthesis #1051: FILE: sound/soc/sof/virtio-be.c:482: +static int sbe_ipc_stream_param_post(struct snd_sof_dev *sdev, + void *ipc_buf, void *reply_buf) CHECK: Prefer kernel type 'u32' over 'uint32_t' #1057: FILE: sound/soc/sof/virtio-be.c:488: + uint32_t comp_id; CHECK: Alignment should match open parenthesis #1073: FILE: sound/soc/sof/virtio-be.c:504: +static int sbe_ipc_post(struct snd_sof_dev *sdev, + void *ipc_buf, void *reply_buf) CHECK: Prefer kernel type 'u32' over 'uint32_t' #1076: FILE: sound/soc/sof/virtio-be.c:507: + uint32_t type, cmd; CHECK: Please don't use multiple blank lines #1103: FILE: sound/soc/sof/virtio-be.c:532: + ERROR: trailing whitespace #1107: FILE: sound/soc/sof/virtio-be.c:536: +static int sbe_ipc_fwd(struct snd_sof_dev *sdev, int vm_id, $ CHECK: Alignment should match open parenthesis #1108: FILE: sound/soc/sof/virtio-be.c:537: +static int sbe_ipc_fwd(struct snd_sof_dev *sdev, int vm_id, + void *ipc_buf, void *reply_buf, CHECK: Prefer kernel type 'u32' over 'uint32_t' #1115: FILE: sound/soc/sof/virtio-be.c:542: + uint32_t type, cmd; CHECK: Prefer kernel type 'u16' over 'uint16_t' #1182: FILE: sound/soc/sof/virtio-be.c:609: + uint16_t idx; WARNING: line over 80 characters #1194: FILE: sound/soc/sof/virtio-be.c:621: + iov.iov_len, sizeof(struct sof_ipc_stream_posn)); WARNING: line over 80 characters #1216: FILE: sound/soc/sof/virtio-be.c:643: + "audio BE notification vq TX kick handling, vq_idx %d\n", vq_idx); CHECK: Unnecessary parentheses around vbe->vqs[vq_idx] #1224: FILE: sound/soc/sof/virtio-be.c:651: + vq = &(vbe->vqs[vq_idx]); WARNING: 'comming' may be misspelled - perhaps 'coming'? #1234: FILE: sound/soc/sof/virtio-be.c:661: +/* IPC commands comming from FE to BE */ CHECK: Unnecessary parentheses around vbe->vqs[vq_idx] #1237: FILE: sound/soc/sof/virtio-be.c:664: + struct virtio_vq_info *vq = &(vbe->vqs[vq_idx]); CHECK: Prefer kernel type 'u16' over 'uint16_t' #1240: FILE: sound/soc/sof/virtio-be.c:667: + uint16_t idx; WARNING: line over 80 characters #1251: FILE: sound/soc/sof/virtio-be.c:678: + //TODO !!! Shouldn't this look like the FE virtio read/write functions ???? CHECK: Blank lines aren't necessary after an open brace '{' #1255: FILE: sound/soc/sof/virtio-be.c:682: + while (virtio_vq_has_descs(vq)) { + CHECK: Alignment should match open parenthesis #1273: FILE: sound/soc/sof/virtio-be.c:700: + virtio_vq_relchain(vq, idx + i, + iov[i].iov_len); ERROR: trailing whitespace #1282: FILE: sound/soc/sof/virtio-be.c:709: +^I^I^I^Ivirtio_vq_relchain(vq, idx, $ CHECK: Alignment should match open parenthesis #1283: FILE: sound/soc/sof/virtio-be.c:710: + virtio_vq_relchain(vq, idx, + iov[SOF_VIRTIO_IPC_MSG].iov_len); CHECK: Alignment should match open parenthesis #1286: FILE: sound/soc/sof/virtio-be.c:713: + virtio_vq_relchain(vq, idx + 1, + iov[SOF_VIRTIO_IPC_REPLY].iov_len); WARNING: line over 80 characters #1299: FILE: sound/soc/sof/virtio-be.c:726: + virtio_vq_relchain(vq, idx, iov[SOF_VIRTIO_IPC_MSG].iov_len); WARNING: line over 80 characters #1300: FILE: sound/soc/sof/virtio-be.c:727: + virtio_vq_relchain(vq, idx + 1, iov[SOF_VIRTIO_IPC_REPLY].iov_len); WARNING: line over 80 characters #1302: FILE: sound/soc/sof/virtio-be.c:729: + // TODO now send the IPC reply from DSP to FE on SOF_VIRTIO_IPC_CMD_RX_VQ WARNING: line over 80 characters #1303: FILE: sound/soc/sof/virtio-be.c:730: + // currently, we doesn't use RX as the reply can share the same memory of TX WARNING: Prefer using '"%s...", __func__' to using 'handle_vq_kick', this function's name, in a string #1313: FILE: sound/soc/sof/virtio-be.c:740: + dev_dbg(vbe->sdev->dev, "handle_vq_kick! vq_idx %d\n", vq_idx); CHECK: Blank lines aren't necessary after an open brace '{' #1360: FILE: sound/soc/sof/virtio-be.c:787: + for (i = 0; i < client->max_vcpu; i++) { + WARNING: Prefer using '"%s...", __func__' to using 'handle_kick', this function's name, in a string #1374: FILE: sound/soc/sof/virtio-be.c:801: + dev_dbg(sdev->dev, "handle_kick: ioreq type %d, direction %d, " WARNING: quoted string split across lines #1375: FILE: sound/soc/sof/virtio-be.c:802: + dev_dbg(sdev->dev, "handle_kick: ioreq type %d, direction %d, " + "addr 0x%llx, size 0x%llx, value 0x%x\n", WARNING: Block comments use * on subsequent lines #1384: FILE: sound/soc/sof/virtio-be.c:811: + /* currently we handle kick only, + so read will return 0 */ WARNING: Block comments use a trailing */ on a separate line #1384: FILE: sound/soc/sof/virtio-be.c:811: + so read will return 0 */ CHECK: Alignment should match open parenthesis #1429: FILE: sound/soc/sof/virtio-be.c:856: + client->vhm_client_id = acrn_ioreq_create_client(vmid, handle_kick, + "sof_vbe kick init\n"); CHECK: Comparison to NULL could be written "!client->req_buf" #1458: FILE: sound/soc/sof/virtio-be.c:885: + if (client->req_buf == NULL) { ERROR: trailing whitespace #1475: FILE: sound/soc/sof/virtio-be.c:902: +/* register SOF audio BE with virtio/acrn */ $ WARNING: Block comments use * on subsequent lines #1502: FILE: sound/soc/sof/virtio-be.c:929: + /* currently relies on VHM to kick us, + thus vq_notify not used */ WARNING: Block comments use a trailing */ on a separate line #1502: FILE: sound/soc/sof/virtio-be.c:929: + thus vq_notify not used */ CHECK: Unnecessary parentheses around vbe->vqs[SOF_VIRTIO_IPC_NOT_RX_VQ] #1520: FILE: sound/soc/sof/virtio-be.c:947: + struct virtio_vq_info *vq = &(vbe->vqs[SOF_VIRTIO_IPC_NOT_RX_VQ]); CHECK: Prefer kzalloc(sizeof(*entry)...) over kzalloc(sizeof(struct vbs_sof_posn)...) #1546: FILE: sound/soc/sof/virtio-be.c:973: + entry = kzalloc(sizeof(struct vbs_sof_posn), GFP_ATOMIC); ERROR: do not set execute permissions for source files #1562: FILE: sound/soc/sof/virtio-fe.c CHECK: Please don't use multiple blank lines #1658: FILE: sound/soc/sof/virtio-fe.c:75: + + CHECK: Please don't use multiple blank lines #1665: FILE: sound/soc/sof/virtio-fe.c:81: + + CHECK: Alignment should match open parenthesis #1668: FILE: sound/soc/sof/virtio-fe.c:84: +static int vfe_send_msg(struct snd_sof_dev *sdev, + struct snd_sof_ipc_msg *msg) CHECK: Alignment should match open parenthesis #1685: FILE: sound/soc/sof/virtio-fe.c:101: + ret = virtqueue_add_outbuf(vfe->ipc_cmd_tx_vq, sgs, 2, + msg->msg_data, GFP_KERNEL); WARNING: braces {} are not necessary for single statement blocks #1686: FILE: sound/soc/sof/virtio-fe.c:102: + if (ret < 0) { + dev_err(sdev->dev, "error: could not send IPC %d\n", ret); + } CHECK: Alignment should match open parenthesis #1700: FILE: sound/soc/sof/virtio-fe.c:113: +static int vfe_get_reply(struct snd_sof_dev *sdev, + struct snd_sof_ipc_msg *msg) ERROR: trailing whitespace #1706: FILE: sound/soc/sof/virtio-fe.c:119: +^I// COMMENT: we should not use virtqueue_get_buf here, it should $ ERROR: space required after that ',' (ctx:VxV) #1748: FILE: sound/soc/sof/virtio-fe.c:156: +static int vfe_cmd_done(struct snd_sof_dev *sdev,int dir) ^ CHECK: Alignment should match open parenthesis #1767: FILE: sound/soc/sof/virtio-fe.c:174: + ret = virtqueue_add_outbuf(vfe->ipc_not_tx_vq, sgs, 1, + not->msg_data, GFP_KERNEL); WARNING: braces {} are not necessary for single statement blocks #1768: FILE: sound/soc/sof/virtio-fe.c:175: + if (ret < 0) { + dev_err(sdev->dev, "error: could not send IPC %d\n", ret); + } ERROR: "foo* bar" should be "foo *bar" #1784: FILE: sound/soc/sof/virtio-fe.c:189: + void* buf = NULL; WARNING: Missing a blank line after declarations #1786: FILE: sound/soc/sof/virtio-fe.c:191: + unsigned int buflen = 0; + buf = virtqueue_get_buf(vq, &buflen); CHECK: Blank lines aren't necessary after an open brace '{' #1805: FILE: sound/soc/sof/virtio-fe.c:202: { + CHECK: Blank lines aren't necessary before a close brace '}' #1806: FILE: sound/soc/sof/virtio-fe.c:203: + +} CHECK: Comparison to NULL could be written "!spcm" #1828: FILE: sound/soc/sof/virtio-fe.c:225: + if (spcm == NULL) { CHECK: Alignment should match open parenthesis #1835: FILE: sound/soc/sof/virtio-fe.c:232: + memcpy(&spcm->stream[direction].posn, posn, + sizeof(struct sof_ipc_stream_posn)); CHECK: Comparison to NULL could be written "!priv" #1856: FILE: sound/soc/sof/virtio-fe.c:253: + if (priv == NULL) CHECK: Comparison to NULL could be written "!sof_pdata" #1860: FILE: sound/soc/sof/virtio-fe.c:257: + if (sof_pdata == NULL) CHECK: Comparison to NULL could be written "!mach" #1866: FILE: sound/soc/sof/virtio-fe.c:263: + if (mach == NULL) CHECK: Alignment should match open parenthesis #1888: FILE: sound/soc/sof/virtio-fe.c:285: + platform_device_register_data(dev, mach->drv_name, -1, + sof_pdata, sizeof(*sof_pdata)); WARNING: line over 80 characters #1893: FILE: sound/soc/sof/virtio-fe.c:290: + dev_dbg(dev, "created machine %s\n", dev_name(&sof_pdata->pdev_mach->dev)); CHECK: Alignment should match open parenthesis #1902: FILE: sound/soc/sof/virtio-fe.c:299: + platform_device_register_data(dev, "sof-audio", -1, + sof_pdata, sizeof(*sof_pdata)); ERROR: trailing whitespace #1905: FILE: sound/soc/sof/virtio-fe.c:302: +^I^I^I(int)PTR_ERR(priv->pdev_pcm));^I$ CHECK: Please don't use multiple blank lines #1923: FILE: sound/soc/sof/virtio-fe.c:320: + + CHECK: Alignment should match open parenthesis #1959: FILE: sound/soc/sof/virtio-fe.c:352: + ret = virtio_find_vqs(vfe->vdev, + SOF_VIRTIO_NUM_OF_VQS, vqs, cbs, sof_vq_names, NULL); CHECK: Prefer kmalloc(sizeof(*vfe->posn)...) over kmalloc(sizeof(struct sof_ipc_stream_posn)...) #1974: FILE: sound/soc/sof/virtio-fe.c:367: + vfe->posn = kmalloc(sizeof(struct sof_ipc_stream_posn), GFP_KERNEL); WARNING: suspect code indent for conditional statements (8, 24) #1976: FILE: sound/soc/sof/virtio-fe.c:369: + if (vfe->ipc_not_rx_vq) { + ret = virtqueue_add_inbuf(vfe->ipc_not_rx_vq, CHECK: Alignment should match open parenthesis #1978: FILE: sound/soc/sof/virtio-fe.c:371: + ret = virtqueue_add_inbuf(vfe->ipc_not_rx_vq, + &sg, 1, vfe->posn, GFP_KERNEL); WARNING: Missing a blank line after declarations #1994: FILE: sound/soc/sof/virtio-fe.c:386: + struct sof_vfe *vfe = vdev->priv; + vdev->config->reset(vdev); ERROR: space required before the open parenthesis '(' #1996: FILE: sound/soc/sof/virtio-fe.c:388: + if(vfe->posn) WARNING: kfree(NULL) is safe and this check is probably not required #1997: FILE: sound/soc/sof/virtio-fe.c:389: + if(vfe->posn) + kfree(vfe->posn); WARNING: space prohibited before semicolon #2002: FILE: sound/soc/sof/virtio-fe.c:394: + return ; WARNING: Block comments use * on subsequent lines #2023: FILE: sound/soc/sof/virtio-fe.c:407: +/*TODO: There still need a shutdown to handle the case the UOS +is poweroff, restart. CHECK: Please don't use multiple blank lines #2055: FILE: sound/soc/sof/virtio-fe.c:432: + + CHECK: Blank lines aren't necessary after an open brace '{' #2058: FILE: sound/soc/sof/virtio-fe.c:435: +struct snd_sof_dsp_ops snd_sof_vfe_ops = { + ERROR: do not set execute permissions for source files #2079: FILE: sound/soc/sof/virtio-miscdev.c CHECK: Alignment should match open parenthesis #2154: FILE: sound/soc/sof/virtio-miscdev.c:71: +static long sof_virtio_ioctl(struct file *f, void *data, unsigned int ioctl, + unsigned long arg) WARNING: line over 80 characters #2171: FILE: sound/soc/sof/virtio-miscdev.c:88: + /* Maybe we should move sof_register_vhm_client() in VBS_SET_DEV */ WARNING: labels should not be indented #2184: FILE: sound/soc/sof/virtio-miscdev.c:101: + defaul: CHECK: Blank lines aren't necessary after an open brace '{' #2193: FILE: sound/soc/sof/virtio-miscdev.c:110: +{ + WARNING: line over 80 characters #2315: FILE: sound/soc/sof/virtio-miscdev.c:232: + // TODO: must be a way to regisuer misc dev with private data so global not needed ERROR: do not set execute permissions for source files #2338: FILE: sound/soc/sof/virtio-miscdev.h WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #2343: FILE: sound/soc/sof/virtio-miscdev.h:1: +/* total: 28 errors, 44 warnings, 71 checks, 2249 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile ./linux-sof-driver/0001-add-sof-mediator-into-github-code.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.